From owner-freebsd-threads@FreeBSD.ORG  Mon Apr  4 20:30:11 2005
Return-Path: <owner-freebsd-threads@FreeBSD.ORG>
Delivered-To: freebsd-threads@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id A54BC16A4CE
	for <freebsd-threads@hub.freebsd.org>;
	Mon,  4 Apr 2005 20:30:11 +0000 (GMT)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 8D3AD43D39
	for <freebsd-threads@hub.freebsd.org>;
	Mon,  4 Apr 2005 20:30:11 +0000 (GMT)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.13.3/8.13.3) with ESMTP id j34KUBZP023434
	for <freebsd-threads@freefall.freebsd.org>;
	Mon, 4 Apr 2005 20:30:11 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.13.3/8.13.1/Submit) id j34KUBM0023433;
	Mon, 4 Apr 2005 20:30:11 GMT
	(envelope-from gnats)
Date: Mon, 4 Apr 2005 20:30:11 GMT
Message-Id: <200504042030.j34KUBM0023433@freefall.freebsd.org>
To: freebsd-threads@FreeBSD.org
From: Craig Rodrigues <rodrigc@crodrigues.org>
Subject: Re: threads/79526: A memory leak in pthread_rwlock_init()
X-BeenThere: freebsd-threads@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
Reply-To: Craig Rodrigues <rodrigc@crodrigues.org>
List-Id: Threading on FreeBSD <freebsd-threads.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-threads>,
	<mailto:freebsd-threads-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-threads>
List-Post: <mailto:freebsd-threads@freebsd.org>
List-Help: <mailto:freebsd-threads-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-threads>,
	<mailto:freebsd-threads-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 04 Apr 2005 20:30:11 -0000

The following reply was made to PR threads/79526; it has been noted by GNATS.

From: Craig Rodrigues <rodrigc@crodrigues.org>
To: Kimmo Mustonen <tzimmo@rommon.com>
Cc: FreeBSD-gnats-submit@freebsd.org
Subject: Re: threads/79526: A memory leak in pthread_rwlock_init()
Date: Mon, 4 Apr 2005 16:25:40 -0400

 On Mon, Apr 04, 2005 at 03:36:02PM +0300, Kimmo Mustonen wrote:
 >         Haven't looked at the sources, but probably easy to fix.
 >         I suppose pthread_rwlock_destroy() just does not free all the
 >         resources pthread_rwlock_init() allocates.
 
 
 Can you try this patch?
 prwlock was being allocated by malloc inside pthread_rwlock_init(),
 but never freed.
 
 
 --- lib/libpthread/thread/thr_rwlock.c.orig	Mon Apr  4 16:22:16 2005
 +++ lib/libpthread/thread/thr_rwlock.c	Mon Apr  4 16:23:26 2005
 @@ -131,6 +131,7 @@
  				prwlock->blocked_writers = 0;
  
  				*rwlock = prwlock;
 +				free(prwlock);
  			}
  		}
  	}
 
 
 -- 
 Craig Rodrigues        
 rodrigc@crodrigues.org