Date: Wed, 14 Dec 2016 10:20:23 +0100 From: Mathieu Arnold <mat@FreeBSD.org> To: Jose Alonso Cardenas Marquez <acm@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r428545 - in head/games: . alienarena alienarena-data Message-ID: <0832fa13-356d-5149-8f53-17cbdffb79ab@FreeBSD.org> In-Reply-To: <201612140448.uBE4mlKd015934@repo.freebsd.org> References: <201612140448.uBE4mlKd015934@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--aMrkIGFMhlfJbhCV8rOAx28iLnUSUmO30
Content-Type: multipart/mixed; boundary="pUVxkBbGBtJdOgf16IBfKVkoFb2PBBN8A";
protected-headers="v1"
From: Mathieu Arnold <mat@FreeBSD.org>
To: Jose Alonso Cardenas Marquez <acm@FreeBSD.org>,
ports-committers@freebsd.org, svn-ports-all@freebsd.org,
svn-ports-head@freebsd.org
Message-ID: <0832fa13-356d-5149-8f53-17cbdffb79ab@FreeBSD.org>
Subject: Re: svn commit: r428545 - in head/games: . alienarena alienarena-data
References: <201612140448.uBE4mlKd015934@repo.freebsd.org>
In-Reply-To: <201612140448.uBE4mlKd015934@repo.freebsd.org>
--pUVxkBbGBtJdOgf16IBfKVkoFb2PBBN8A
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Le 14/12/2016 =C3=A0 05:48, Jose Alonso Cardenas Marquez a =C3=A9crit :
> .if ${PORT_OPTIONS:MCLIENT}
> @@ -56,8 +52,9 @@ USES+=3D openal:soft,alut pkgconfig
> LIB_DEPENDS+=3D libcurl.so:${PORTSDIR}/ftp/curl \
> libfreetype.so:${PORTSDIR}/print/freetype2 \
> libjpeg.so:${PORTSDIR}/graphics/jpeg \
> - libpng15.so:${PORTSDIR}/graphics/png \
> + libpng16.so:${PORTSDIR}/graphics/png \
> libvorbis.so:${PORTSDIR}/audio/libvorbis
> +BUILD_DEPENDS+=3D ${LOCALBASE}/lib/libode.a:devel/ode
> USE_GL=3D yes
> USE_XORG=3D xxf86dga xxf86vm
> .endif
> @@ -79,24 +76,27 @@ PLIST_SUB+=3D DEDICATED=3D"@comment "
> .endif
All the options handling before would be done better using options
helpers, and by defining OPTION_SUB.
> =20
> do-install:
> - ${MKDIR} ${LIBDIR}/arena ${LIBDIR}/data1
> - ${LN} -s ${DATADIR}/arena/* ${LIBDIR}/arena
> - ${LN} -s ${DATADIR}/botinfo ${LIBDIR}
> - ${LN} -s ${DATADIR}/data1/* ${LIBDIR}/data1
> + ${MKDIR} ${STAGEDIR}${LIBDIR}/arena ${STAGEDIR}${LIBDIR}/data1
> + ${LN} -s ${DATADIR}/arena/* ${STAGEDIR}${LIBDIR}/arena
> + ${LN} -s ${DATADIR}/botinfo ${STAGEDIR}${LIBDIR}
> + ${LN} -s ${DATADIR}/data1/* ${STAGEDIR}${LIBDIR}/data1
> .if ${PORT_OPTIONS:MCLIENT}
> ${INSTALL_PROGRAM} ${WRKSRC}/${PORTNAME} \
> - ${PREFIX}/bin/${PORTNAME}
> + ${STAGEDIR}${PREFIX}/bin/${PORTNAME}
> .endif
> .if ${PORT_OPTIONS:MDEDICATED}
> ${INSTALL_PROGRAM} ${WRKSRC}/${PORTNAME}-ded \
> - ${PREFIX}/bin/${PORTNAME}-ded
> + ${STAGEDIR}${PREFIX}/bin/${PORTNAME}-ded
> .endif
> =20
Same here, use options target helpers.
> post-install:
>
The post-install target should be removed, it echo's the pkg message
file, which is already done when the package is installed.
--=20
Mathieu Arnold
--pUVxkBbGBtJdOgf16IBfKVkoFb2PBBN8A--
--aMrkIGFMhlfJbhCV8rOAx28iLnUSUmO30
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
iQJ8BAEBCgBmBQJYUQ7YXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQzQUI2OTc4OUQyRUQxMjEwNjQ0MEJBNUIz
QTQ1MTZGMzUxODNDRTQ4AAoJEDpFFvNRg85I4jEP/2YtsAI8ST7ZZ59R6wKc8JV5
VFb8esKFpNonUeDIo2LVoGtPfG4L4qdGWwehP2FIecezRrIvD9FTeqQD9gHPp5WX
WiyKs/V3hyrSS7adkHnupMmo+ClNRGOOBC5wehCR592NNkqP6ZuMvSBe5ilNR4Sw
rFbRayj8ckJ0RUbI/b2o5yJOAbrHIprDh6SXMeP1rsUIjPUZ1FijyzAVjBtRgviV
mBid7UQq7ilFUJDLAwoWHSvge6nP0LjRRZjxPg+flUHvtF3GJ+tJvluHWwDg3liy
eCUvSpfPi3etjFKM6gV2XKwBJGEYC5SNe3ZN/iLpuaL3KaiWuKAAPvswX+EDLhXm
NdUldAvUmv4nvEfpJ5pJ5kQtcPLq7Kus5SJJwCweH9CQihNZPltJraqbD6NEZjFm
Ol341xTe5Dx71252AbyF0oVjg9+EC2cOClZljxpK2VUTAl9q9dNze+EUXWOnMH6z
rZycwyOiXy2Y9sCIMOh6iPyulkGT5Q13OJqNFdfYJV6mgDkwwQ6nZHKuUBkb43qQ
bsPvNNKuGABrhGtgO0vzkoK36FHtc0pkWFjniDv8wqKAo7z3usZNWE4Cq4V3DoM7
WovNnosqF7llZnmCbCC7d+7Z93wezs5YhGzmt8NPhICIM/7nQmXL7tmkOl56Fisr
Wt9Fc1Rd6MkvZCy/7K3u
=SX/W
-----END PGP SIGNATURE-----
--aMrkIGFMhlfJbhCV8rOAx28iLnUSUmO30--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?0832fa13-356d-5149-8f53-17cbdffb79ab>