From nobody Tue Apr 18 23:22:06 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Q1Kgz0l8zz45qhQ; Tue, 18 Apr 2023 23:22:07 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Q1Kgy1fW4z4Sxb; Tue, 18 Apr 2023 23:22:06 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1681860126; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=TT4UZeRtuQqencAy+e5FVwMWjCEhUFZMrKsN11QH9Zs=; b=JHxzOEVkCAx61TPMYat9AvK6b+Kxt8+pU6y0hSDTFXLDwONtofanTwUCfUW9gGYRqua4Gy k3zu0olgaWXAl0porR3RUj+WjCloapQtbbXMuK8jK9OX3VDXwJPqKyV+fwYuN2fOJJZzp6 +xwusP9bfSshvwvQGKOj+BaKNExCUQHhfZpAhVcWulwujllbNQ5F5weUj0KA6kojI/DaRR 3RUG3RHzO4FnIRYk+MPmR9ztSPPV1tsHRt5UGv2T5PI1tcQ8mB55kgtHXONpjQ9L/2rOlg DsmBoAq0sDoEDb13INvyxHRXhIFxo4JxJJ7uwsqxxpRy5SlY3poWXpf2lq/fSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1681860126; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=TT4UZeRtuQqencAy+e5FVwMWjCEhUFZMrKsN11QH9Zs=; b=r1zAluekCFAFz1d654yNar6sGf2PVvhNLKrXjQafATs/fCe4PstmXiMTKWQ19WlYKTTReg MY/JbBuS7oAgV77RyCi2wCD6OcRX2sT4PMBBvcV1vbo1BRZPup87c1tqKMfXTzxYEhyBOn YsZgqJrhAtj45dN5DlcXE7tyG293k8TfvLmXqekD5ddNIkdRQ56XfrYZwV2UVFDFcoiI2t ignh0EksEbLjqZIEx5E8CnvZdJvIQO5rKbBG59ikrHY5NW39tYSQHqjI0dPMRSzKmS6ycr 43My97JqB4Byn2yJfQpFozms3vg1tXKMxThejlUU/raozOYtH+PE1DuQgclS8Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1681860126; a=rsa-sha256; cv=none; b=qsH1HxGtUqKu+BBctz1qTKgk/z5LzBFLWJiMAOer26kaL1ceh12VTRppi3lWA97uffNd26 ikdhVeePoTaCthjo+01jpZfVdiznBQlCIis+sXZtfyVpk6QAtTa/mH6jmoanwyDydBzr3o H43fdWFyyclV+FO+MsZvFGALKhcHFn2eotNcLEFKRSatNB+iRnEgVYxWxaOSpoMlAXuI4W 2giNTwboFwMI6T0fJv9uRkBWh49h8dnbwwl3zhNQj5Ed0cndClq8/uyGCGtWT+XmZY+xOF 6x3lONqcr18MdXhfleTIw8pWT9rUaQSngPRbLdVzTkBgLvuBT4Gnb5YTcxOEfQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Q1Kgy0lrXzWrw; Tue, 18 Apr 2023 23:22:06 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 33INM6YT011416; Tue, 18 Apr 2023 23:22:06 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 33INM6n9011415; Tue, 18 Apr 2023 23:22:06 GMT (envelope-from git) Date: Tue, 18 Apr 2023 23:22:06 GMT Message-Id: <202304182322.33INM6n9011415@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Konstantin Belousov Subject: git: d8a096621bcf - main - sync_vnode(): add assert to check vn_start_write() correctness List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kib X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: d8a096621bcf4539d0920eb0711d19fcb30c0576 Auto-Submitted: auto-generated X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by kib: URL: https://cgit.FreeBSD.org/src/commit/?id=d8a096621bcf4539d0920eb0711d19fcb30c0576 commit d8a096621bcf4539d0920eb0711d19fcb30c0576 Author: Konstantin Belousov AuthorDate: 2023-04-15 19:41:44 +0000 Commit: Konstantin Belousov CommitDate: 2023-04-18 23:21:40 +0000 sync_vnode(): add assert to check vn_start_write() correctness Tested by: pho Sponsored by: The FreeBSD Foundation MFC after: 1 week --- sys/kern/vfs_subr.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sys/kern/vfs_subr.c b/sys/kern/vfs_subr.c index 60d3a71667a1..475467da3c34 100644 --- a/sys/kern/vfs_subr.c +++ b/sys/kern/vfs_subr.c @@ -2659,6 +2659,9 @@ sync_vnode(struct synclist *slp, struct bufobj **bo, struct thread *td) mtx_lock(&sync_mtx); return (*bo == LIST_FIRST(slp)); } + MPASSERT(mp == NULL || (curthread->td_pflags & TDP_IGNSUSP) != 0 || + (mp->mnt_kern_flag & MNTK_SUSPENDED) == 0, mp, + ("suspended mp syncing vp %p", vp)); vn_lock(vp, LK_EXCLUSIVE | LK_RETRY); (void) VOP_FSYNC(vp, MNT_LAZY, td); VOP_UNLOCK(vp);