From owner-svn-src-all@FreeBSD.ORG  Fri Oct  8 21:37:42 2010
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id EE07010657DC;
	Fri,  8 Oct 2010 21:37:38 +0000 (UTC)
	(envelope-from brde@optusnet.com.au)
Received: from mail09.syd.optusnet.com.au (mail09.syd.optusnet.com.au
	[211.29.132.190])
	by mx1.freebsd.org (Postfix) with ESMTP id 91FFB8FC16;
	Fri,  8 Oct 2010 21:37:37 +0000 (UTC)
Received: from c122-106-146-165.carlnfd1.nsw.optusnet.com.au
	(c122-106-146-165.carlnfd1.nsw.optusnet.com.au [122.106.146.165])
	by mail09.syd.optusnet.com.au (8.13.1/8.13.1) with ESMTP id
	o98LbJSd008394
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Sat, 9 Oct 2010 08:37:35 +1100
Date: Sat, 9 Oct 2010 08:37:19 +1100 (EST)
From: Bruce Evans <brde@optusnet.com.au>
X-X-Sender: bde@besplex.bde.org
To: Peter Holm <pho@freebsd.org>
In-Reply-To: <201010081027.o98ARrUQ087673@svn.freebsd.org>
Message-ID: <20101009082104.X1487@besplex.bde.org>
References: <201010081027.o98ARrUQ087673@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org
Subject: Re: svn commit: r213568 - head/sys/boot/i386/gptboot
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 08 Oct 2010 21:37:42 -0000

On Fri, 8 Oct 2010, Peter Holm wrote:

> Log:
>  Ensure that a make from sys/boot does not pick up include files from
>  /usr/include.
>
>  Discussed with:	 kib
>
> Modified:
>  head/sys/boot/i386/gptboot/Makefile
>
> Modified: head/sys/boot/i386/gptboot/Makefile
> ==============================================================================
> --- head/sys/boot/i386/gptboot/Makefile	Fri Oct  8 09:43:06 2010	(r213567)
> +++ head/sys/boot/i386/gptboot/Makefile	Fri Oct  8 10:27:52 2010	(r213568)
> @@ -36,6 +36,7 @@ CFLAGS=	-DBOOTPROG=\"gptboot\" \
> 	-I${.CURDIR}/../common \
> 	-I${.CURDIR}/../btx/lib -I. \
> 	-I${.CURDIR}/../boot2 \
> +	-I${.CURDIR}/../../.. \
> 	-Wall -Waggregate-return -Wbad-function-cast -Wcast-align \
> 	-Wmissing-declarations -Wmissing-prototypes -Wnested-externs \
> 	-Wpointer-arith -Wshadow -Wstrict-prototypes -Wwrite-strings \
>

This should be handled by setting -nostdinc in the top-level Makefile.inc,
as was done in 1998 or earlier by sys/i386/boot/Makefile.inc (the
sys/boot hierarchy is still of amazingly lower quality than the
sys/i386/boot hierarchy), or in a central foo.mk Makefile as is done
for kernels and modules.

Bruce