From owner-p4-projects Fri Aug 2 6:17:35 2002 Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id B80EC37B401; Fri, 2 Aug 2002 06:17:30 -0700 (PDT) Delivered-To: perforce@freebsd.org Received: from green.bikeshed.org (freefall.FreeBSD.org [216.136.204.21]) by hub.freebsd.org (Postfix) with ESMTP id 8A55B37B400; Fri, 2 Aug 2002 06:17:29 -0700 (PDT) Received: from localhost (green@localhost) by green.bikeshed.org (8.11.6/8.11.6) with ESMTP id g72D6w535383; Fri, 2 Aug 2002 09:06:58 -0400 (EDT) (envelope-from green@green.bikeshed.org) Message-Id: <200208021306.g72D6w535383@green.bikeshed.org> X-Mailer: exmh version 2.5 07/13/2001 with nmh-1.0.4 To: John Baldwin Cc: Brian Feldman , Perforce Change Reviews Subject: Re: PERFORCE change 15347 for review In-Reply-To: Your message of "Thu, 01 Aug 2002 10:11:59 EDT." From: "Brian F. Feldman" Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Fri, 02 Aug 2002 09:06:58 -0400 Sender: owner-p4-projects@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG John Baldwin wrote: > > On 31-Jul-2002 Brian Feldman wrote: > > http://people.freebsd.org/~peter/p4db/chv.cgi?CH=15347 > > > > Change 15347 by green@green_laptop_2 on 2002/07/31 14:31:24 > > > > mac_cred_canexec() no longer exists; use mac_check_vnode_exec(). > > Dropping the proc lock invalidates the credential changes and any > earlier credential changes you just made unless you ensure that the > process is single threaded before you do any of the credential > checks and before you get here. This is something that needs to be fixed by people that understand teh KSE stuff by, like you said, ensuring that the process is single-threaded here. That should be the very first thing exec does... I personally had no idea whether it should return an error, destroy all the other threads, fork off a new process surreptititiously (eek!), or whatever else could possibly be the answer for it. -- Brian Fundakowski Feldman \'[ FreeBSD ]''''''''''\ <> green@FreeBSD.org <> bfeldman@tislabs.com \ The Power to Serve! \ Opinions expressed are my own. \,,,,,,,,,,,,,,,,,,,,,,\ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe p4-projects" in the body of the message