From owner-freebsd-ports-bugs@FreeBSD.ORG Thu Jun 2 21:10:10 2011 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4052A1065672 for ; Thu, 2 Jun 2011 21:10:10 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 155C78FC1A for ; Thu, 2 Jun 2011 21:10:10 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id p52LA9d1066850 for ; Thu, 2 Jun 2011 21:10:09 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id p52LA9EB066849; Thu, 2 Jun 2011 21:10:09 GMT (envelope-from gnats) Resent-Date: Thu, 2 Jun 2011 21:10:09 GMT Resent-Message-Id: <201106022110.p52LA9EB066849@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Chris Rees Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D0A39106566B for ; Thu, 2 Jun 2011 21:05:53 +0000 (UTC) (envelope-from utisoft@hotmail.com) Received: from blu0-omc1-s2.blu0.hotmail.com (blu0-omc1-s2.blu0.hotmail.com [65.55.116.13]) by mx1.freebsd.org (Postfix) with ESMTP id 877478FC12 for ; Thu, 2 Jun 2011 21:05:53 +0000 (UTC) Received: from BLU0-SMTP112 ([65.55.116.8]) by blu0-omc1-s2.blu0.hotmail.com with Microsoft SMTPSVC(6.0.3790.4675); Thu, 2 Jun 2011 14:05:53 -0700 Received: from zeus.bayofrum.net ([90.221.7.100]) by BLU0-SMTP112.phx.gbl over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Thu, 2 Jun 2011 14:05:50 -0700 Received: from zeus.bayofrum.net (crees@localhost [127.0.0.1]) by zeus.bayofrum.net (8.14.4/8.14.4) with ESMTP id p52L11vI058928 (version=TLSv1/SSLv3 cipher=DHE-DSS-AES256-SHA bits=256 verify=NO) for ; Thu, 2 Jun 2011 22:01:01 +0100 (BST) (envelope-from crees@zeus.bayofrum.net) Received: (from crees@localhost) by zeus.bayofrum.net (8.14.4/8.14.4/Submit) id p52L11iI058896; Thu, 2 Jun 2011 22:01:01 +0100 (BST) (envelope-from crees) Message-Id: Date: Thu, 2 Jun 2011 22:01:01 +0100 From: Chris Rees Sender: To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: ports/157545: [PATCH] comms/gnokii should use GROUPS= X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Chris Rees List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Jun 2011 21:10:10 -0000 >Number: 157545 >Category: ports >Synopsis: [PATCH] comms/gnokii should use GROUPS= >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Thu Jun 02 21:10:09 UTC 2011 >Closed-Date: >Last-Modified: >Originator: Chris Rees >Release: FreeBSD 8.2-RELEASE-p1 i386 >Organization: bayofrum >Environment: System: FreeBSD zeus.bayofrum.net 8.2-RELEASE-p1 FreeBSD 8.2-RELEASE-p1 #0: Sat Apr 30 15:09:06 BST 2011 root@zeus.bayofrum.net:/usr/obj/usr/src/sys/ZEUS i386 >Description: This port uses pkg-install to create new groups instead of using GROUPS=. It also removes the group on deinstall, which could break other installed ports. >How-To-Repeat: >Fix: - Use GROUPS - Stop removing GROUPS on deinstall Submitted by: Chris Rees (utisoft@gmail.com) This PR depends on ports/157528 -- the gnokii group isn't in GIDs as of yet --- comms-gnokii.patch begins here --- Index: Makefile =================================================================== RCS file: /exports/cvsroot-freebsd/ports/comms/gnokii/Makefile,v retrieving revision 1.88 diff -u -r1.88 Makefile --- Makefile 26 Jan 2011 13:47:03 -0000 1.88 +++ Makefile 2 Jun 2011 11:42:06 -0000 @@ -21,6 +21,7 @@ BUILD_DEPENDS= ${SITE_PERL}/${PERL_ARCH}/XML/Parser.pm:${PORTSDIR}/textproc/p5-XML-Parser +GROUPS= ${PORTNAME} USE_BZIP2= yes USE_GMAKE= yes USE_GETTEXT= yes @@ -38,7 +39,6 @@ LIBS="-L${WRKSRC}/common -L${LOCALBASE}/lib" \ PKG_CONFIG="${LOCALBASE}/bin/pkg-config" -PKGDEINSTALL= ${PKGINSTALL} SUB_FILES+= pkg-message PORTDOCS= * MAN1= gnokii.1 sendsms.1 xgnokii.1 @@ -126,9 +126,6 @@ ${WRKSRC}/${CONFIGURE_SCRIPT} @${MV} ${WRKSRC}/Docs/man/xgnokii.1x ${WRKSRC}/Docs/man/xgnokii.1 -pre-install: - @${SETENV} "PKG_PREFIX=${PREFIX}" ${SH} ${PKGINSTALL} ${PKGNAME} PRE-INSTALL - post-install: ${INSTALL_DATA} ${WRKSRC}/xgnokii/xgnokii.pc ${PREFIX}/libdata/pkgconfig @${SETENV} "PKG_PREFIX=${PREFIX}" ${SH} ${PKGINSTALL} ${PKGNAME} POST-INSTALL Index: pkg-install =================================================================== RCS file: /exports/cvsroot-freebsd/ports/comms/gnokii/pkg-install,v retrieving revision 1.2 diff -u -r1.2 pkg-install --- pkg-install 13 Nov 2005 18:28:39 -0000 1.2 +++ pkg-install 2 Jun 2011 11:41:19 -0000 @@ -2,8 +2,6 @@ PATH=/bin:/usr/bin:/usr/sbin -GROUP=gnokii - SUIDBINS="${PKG_PREFIX}/sbin/gnokiid ${PKG_PREFIX}/sbin/mgnokiidev" BINS="${PKG_PREFIX}/bin/gnokii ${SUIDBINS}" @@ -12,30 +10,10 @@ fi case "$2" in -"PRE-INSTALL") - if pw group show "${GROUP}" 2>/dev/null; then - echo "You already have a group \"${GROUP}\", so I will use it." - else - if pw groupadd ${GROUP}; then - echo "Added group \"${GROUP}\"." - else - echo "Adding group \"${GROUP}\" failed..." - exit 1 - fi - fi - ;; - "POST-INSTALL") chgrp $GROUP $BINS chmod 750 ${BINS} chmod u+s ${SUIDBINS} ;; -"DEINSTALL") - if [ -z "`pw groupshow $GROUP 2>&1 | sed -E -e 's/^([^:]+:){3}(.*)$/\2/'`" ]; then - echo "Removing empty group \"$GROUP\"." - pw groupdel $GROUP - fi - ;; - esac --- comms-gnokii.patch ends here --- -- This message has been scanned for viruses and dangerous content by MailScanner, and is believed to be clean. >Release-Note: >Audit-Trail: >Unformatted: