Date: Thu, 29 Sep 2005 18:40:36 +0000 (UTC) From: Robert Watson <rwatson@FreeBSD.org> To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/sys/kern subr_prf.c src/sys/nfsclient nfs_socket.c src/sys/rpc rpcclnt.c Message-ID: <200509291840.j8TIeaKK061810@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
rwatson 2005-09-29 18:40:36 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/kern subr_prf.c sys/nfsclient nfs_socket.c sys/rpc rpcclnt.c Log: Merge subr_prof.c:1.119, 1.120, 1.121, nfs_socket.c:1.130, rpcclnt.c:1.14 from HEAD to RELENG_6: Acquire Giant in uprintf() and tprintf() due to the non-MPSAFEty of the tty code invoked from these functions. In two cases, during timeout handling in NFS-related RPC client code, acquire Giant in the caller before other mutexes the caller might hold, in order to avoid lock order reversals with Giant (a recursive acquire is not a reversal as it won't ever wait). Correct age-old comments about uprintf()/tprintf() sleeping: they will never sleep. Much useful feedback from: bde Approved by: re (scottl) Revision Changes Path 1.116.2.2 +13 -8 src/sys/kern/subr_prf.c 1.125.2.2 +13 -1 src/sys/nfsclient/nfs_socket.c 1.13.2.1 +8 -1 src/sys/rpc/rpcclnt.c
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200509291840.j8TIeaKK061810>