From owner-cvs-src@FreeBSD.ORG Fri Aug 29 20:31:53 2008 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 97C201065684; Fri, 29 Aug 2008 20:31:53 +0000 (UTC) (envelope-from marius@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 8685F8FC14; Fri, 29 Aug 2008 20:31:53 +0000 (UTC) (envelope-from marius@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.2/8.14.2) with ESMTP id m7TKVrn1087095; Fri, 29 Aug 2008 20:31:53 GMT (envelope-from marius@repoman.freebsd.org) Received: (from svn2cvs@localhost) by repoman.freebsd.org (8.14.2/8.14.1/Submit) id m7TKVrNO087094; Fri, 29 Aug 2008 20:31:53 GMT (envelope-from marius@repoman.freebsd.org) Message-Id: <200808292031.m7TKVrNO087094@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: svn2cvs set sender to marius@repoman.freebsd.org using -f From: Marius Strobl Date: Fri, 29 Aug 2008 20:31:41 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/dc if_dc.c if_dcreg.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Aug 2008 20:31:53 -0000 marius 2008-08-29 20:31:41 UTC FreeBSD src repository Modified files: sys/dev/dc if_dc.c if_dcreg.h Log: SVN rev 182461 on 2008-08-29 20:31:41Z by marius For chips with a broken DC_ISR_RX_STATE which f.e. never signals stopped nor the waiting state and also no other means to check whether the receiver is idle (see also r163774), we have no choice than to call mii_tick(9) unconditionally even in the case of the DC_REDUCED_MII_POLL handling as far as the RX side is concerned. This isn't necessarily worse than checking whether RX is idle though because unlike as with TX we're racing with the hardware, which might receive packets any time while we poll the MII, anyway. Reported and tested by: Jacob Owens Reviewed by: yongari MFC after: 3 days Revision Changes Path 1.197 +7 -5 src/sys/dev/dc/if_dc.c 1.56 +4 -0 src/sys/dev/dc/if_dcreg.h