From owner-svn-src-head@FreeBSD.ORG Sun Sep 7 21:18:24 2014 Return-Path: Delivered-To: svn-src-head@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 7578B39A; Sun, 7 Sep 2014 21:18:24 +0000 (UTC) Received: from zxy.spb.ru (zxy.spb.ru [195.70.199.98]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 2E50D1D7B; Sun, 7 Sep 2014 21:18:24 +0000 (UTC) Received: from slw by zxy.spb.ru with local (Exim 4.82 (FreeBSD)) (envelope-from ) id 1XQjqo-0000mm-BP; Mon, 08 Sep 2014 01:18:22 +0400 Date: Mon, 8 Sep 2014 01:18:22 +0400 From: Slawa Olhovchenkov To: Andriy Gapon Subject: Re: svn commit: r260713 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs Message-ID: <20140907211822.GD1763@zxy.spb.ru> References: <201401161324.s0GDOADB008512@svn.freebsd.org> <20140907155641.GB72244@zxy.spb.ru> <540CC991.3070604@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <540CC991.3070604@FreeBSD.org> User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: slw@zxy.spb.ru X-SA-Exim-Scanned: No (on zxy.spb.ru); SAEximRunCond expanded to false Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 07 Sep 2014 21:18:24 -0000 On Mon, Sep 08, 2014 at 12:09:37AM +0300, Andriy Gapon wrote: > on 07/09/2014 18:56 Slawa Olhovchenkov said the following: > > On Thu, Jan 16, 2014 at 01:24:10PM +0000, Andriy Gapon wrote: > > > >> Author: avg > >> Date: Thu Jan 16 13:24:10 2014 > >> New Revision: 260713 > >> URL: http://svnweb.freebsd.org/changeset/base/260713 > >> > >> Log: > >> fix a bug in ZFS mirror code for handling multiple DVAa > >> > >> The bug was introduced in r256956 "Improve ZFS N-way mirror read > >> performance". > >> The code in vdev_mirror_dva_select erroneously considers already > >> tried DVAs for the next attempt. Thus, it is possible that a failing DVA > >> would be retried forever. > >> As a secondary effect, if the attempts fail with checksum error, then > >> checksum error reports are accumulated until the original request > >> ultimately fails or succeeds. But because retrying is going on indefinitely > >> the cheksum reports accumulation will effectively be a memory leak. > >> > >> Reviewed by: gibbs > >> MFC after: 13 days > >> Sponsored by: HybridCluster > > > > No NFC yet > > > > Is r256956 MFC-ed yet? Yes, I already see r256956 not MFC too.