Date: Fri, 8 Feb 2002 00:04:48 +0100 (CET)
From: Christian Weisgerber <naddy@mips.inka.de>
To: FreeBSD-gnats-submit@freebsd.org
Subject: ports/34717: bsd.port.mk: extraneous quotes in PTHREAD_{CFLAGS,LIBS}
Message-ID: <200202072304.g17N4m374266@kemoauc.mips.inka.de>
next in thread | raw e-mail | index | archive | help
>Number: 34717
>Category: ports
>Synopsis: bsd.port.mk: extraneous quotes in PTHREAD_{CFLAGS,LIBS}
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Thu Feb 07 15:10:06 PST 2002
>Closed-Date:
>Last-Modified:
>Originator: Christian Weisgerber
>Release: FreeBSD 5.0-CURRENT alpha
>Organization:
>Environment:
System: FreeBSD kemoauc.mips.inka.de 5.0-CURRENT FreeBSD 5.0-CURRENT #0: Sat Jan 19 07:02:33 CET 2002 naddy@kemoauc.mips.inka.de:/usr/obj/usr/src/sys/KEMOAUC alpha
>Description:
The definitions of PTHREAD_CFLAGS and PTHREAD_LIBS have extraneous
quotes that can produce unexpected results when embedding them in
other variables, e.g.
MAKE_FLAGS= CFLAGS='${CFLAGS} ${PTHREAD_FLAGS} -DFOO=\"bar\"'
will unexpectedly break on -CURRENT.
>How-To-Repeat:
>Fix:
Index: bsd.port.mk
===================================================================
RCS file: /home/ncvs/ports/Mk/bsd.port.mk,v
retrieving revision 1.397
diff -u -r1.397 bsd.port.mk
--- bsd.port.mk 24 Jan 2002 01:15:03 -0000 1.397
+++ bsd.port.mk 7 Feb 2002 22:49:09 -0000
@@ -1068,11 +1068,11 @@
MAKE_ENV+= PREFIX=${PREFIX} LOCALBASE=${LOCALBASE} X11BASE=${X11BASE} MOTIFLIB="${MOTIFLIB}" LIBDIR="${LIBDIR}" CFLAGS="${CFLAGS}" CXXFLAGS="${CXXFLAGS}"
.if ${OSVERSION} < 500016
-PTHREAD_CFLAGS= -D_THREAD_SAFE
-PTHREAD_LIBS= "-pthread"
+PTHREAD_CFLAGS= -D_THREAD_SAFE
+PTHREAD_LIBS= -pthread
.else
-PTHREAD_CFLAGS= ""
-PTHREAD_LIBS= "-lc_r"
+PTHREAD_CFLAGS=
+PTHREAD_LIBS= -lc_r
.endif
.if exists(/usr/bin/fetch)
>Release-Note:
>Audit-Trail:
>Unformatted:
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200202072304.g17N4m374266>