From owner-freebsd-scsi@FreeBSD.ORG Mon Nov 20 01:19:52 2006 Return-Path: X-Original-To: freebsd-scsi@freebsd.org Delivered-To: freebsd-scsi@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 945FA16A523; Mon, 20 Nov 2006 01:19:52 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.FreeBSD.org (Postfix) with ESMTP id D272443DBA; Mon, 20 Nov 2006 01:16:42 +0000 (GMT) (envelope-from scottl@samsco.org) Received: from [192.168.254.11] (phobos.samsco.home [192.168.254.11]) (authenticated bits=0) by pooker.samsco.org (8.13.4/8.13.4) with ESMTP id kAK1GYxH053491; Sun, 19 Nov 2006 18:16:39 -0700 (MST) (envelope-from scottl@samsco.org) Message-ID: <456101EF.1070609@samsco.org> Date: Sun, 19 Nov 2006 18:16:31 -0700 From: Scott Long User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.0.7) Gecko/20060910 SeaMonkey/1.0.5 MIME-Version: 1.0 To: mjacob@freebsd.org References: <20061119161631.L44297@ns1.feral.com> <3bbf2fe10611191631h6883b862uf8088533913a7bc6@mail.gmail.com> <20061119164455.I44297@ns1.feral.com> <3bbf2fe10611191657gaaf90ecyd6ac3e41ae59992f@mail.gmail.com> <20061119170554.K45489@ns1.feral.com> In-Reply-To: <20061119170554.K45489@ns1.feral.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.4 required=3.8 tests=ALL_TRUSTED autolearn=failed version=3.1.1 X-Spam-Checker-Version: SpamAssassin 3.1.1 (2006-03-10) on pooker.samsco.org Cc: Attilio Rao , freebsd-scsi@freebsd.org Subject: Re: a code reduction function addition to cam_xpt X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Nov 2006 01:19:52 -0000 mjacob@freebsd.org wrote: > >> Erm, we make large use of variadic macros into the code :) > > Yes. I think that if the code is never going to get backported to FBSD5 > or earlier, it's probably fair enough to use, but for the aesthetics. You mean FreeBSD 4 or FreeBSD 5? CAM is about to be pretty unportable back to FreeBSD 4 for other reasons. Scott