From owner-cvs-src@FreeBSD.ORG  Fri Nov 14 09:25:52 2003
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id B5C7716A4D6; Fri, 14 Nov 2003 09:25:52 -0800 (PST)
Received: from fledge.watson.org (fledge.watson.org [204.156.12.50])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 65B5D43FAF; Fri, 14 Nov 2003 09:25:50 -0800 (PST)
	(envelope-from robert@fledge.watson.org)
Received: from fledge.watson.org (localhost [127.0.0.1])
	by fledge.watson.org (8.12.9p2/8.12.9) with ESMTP id hAEHNtMg019660;
	Fri, 14 Nov 2003 12:23:55 -0500 (EST)
	(envelope-from robert@fledge.watson.org)
Received: from localhost (robert@localhost)hAEHNsCh019657;
	Fri, 14 Nov 2003 12:23:54 -0500 (EST)
	(envelope-from robert@fledge.watson.org)
Date: Fri, 14 Nov 2003 12:23:54 -0500 (EST)
From: Robert Watson <rwatson@FreeBSD.org>
X-Sender: robert@fledge.watson.org
To: John Baldwin <jhb@FreeBSD.org>
In-Reply-To: <XFMail.20031114113017.jhb@FreeBSD.org>
Message-ID: <Pine.NEB.3.96L.1031114122317.18149C-100000@fledge.watson.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
cc: Brian Feldman <green@FreeBSD.org>
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
cc: cvs-src@FreeBSD.org
Subject: RE: cvs commit: src/sys/conf kern.post.mk kmod.mk
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 14 Nov 2003 17:25:52 -0000


On Fri, 14 Nov 2003, John Baldwin wrote:

> On 14-Nov-2003 Brian Feldman wrote:
> > green       2003/11/14 08:04:11 PST
> > 
> >   FreeBSD src repository
> > 
> >   Modified files:
> >     sys/conf             kern.post.mk kmod.mk 
> >   Log:
> >   Include opt_global.h in the modules build, when building from a normal
> >   kernel build.  This makes it possible for me not to get pissed off that
> >   random.ko crashes the system trying to rdtsc() when the i386/cpu.h
> >   support code decides it's okay to call that op when neither I386_CPU or
> >   I486_CPU is defined.  I guess it also makes WITNESS/INVARIANTS defines
> >   get picked up by the modules.
> 
> WITNESS doesn't matter as all calls to it are done in the actual locking
> code itself which does not lives in modules.  Modules always call the
> locking functions and don't inline locking operations. 

I'd have picked up the syntax error in mac_test.c if this had been in
place then :-).   And it makes mac_test and other regression test modules
far more functional...

Robert N M Watson             FreeBSD Core Team, TrustedBSD Projects
robert@fledge.watson.org      Network Associates Laboratories