Date: Thu, 18 Dec 2014 09:51:20 -0600 From: Bryan Drewery <bdrewery@FreeBSD.org> To: Baptiste Daroussin <bapt@FreeBSD.org> Cc: svn-ports-head@freebsd.org, Alexey Dokuchaev <danfe@FreeBSD.org>, svn-ports-all@freebsd.org, ports-committers@freebsd.org, Mathieu Arnold <mat@FreeBSD.org>, Alex Kozlov <ak@FreeBSD.org> Subject: Re: svn commit: r374800 - head/Mk/Uses Message-ID: <5492F7F8.7080801@FreeBSD.org> In-Reply-To: <20141218111154.GA21894@ivaldir.etoilebsd.net> References: <201412161206.sBGC6fa5045717@svn.freebsd.org> <54902709.9090801@marino.st> <71EBD6FD6D89266B6651554A@ogg.in.absolight.net> <20141216133802.GA27647@ravenloft.kiev.ua> <5B209A4BD7689CD74744CFA7@ogg.in.absolight.net> <20141216141320.GA28332@ravenloft.kiev.ua> <20141216142422.GA38033@FreeBSD.org> <5490DFDB.5080000@FreeBSD.org> <20141218111154.GA21894@ivaldir.etoilebsd.net>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --U786P4eRCA2JueUSxFN3cavqQUNBjQoTv Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 12/18/2014 5:11 AM, Baptiste Daroussin wrote: > On Tue, Dec 16, 2014 at 07:43:55PM -0600, Bryan Drewery wrote: >> On 12/16/2014 8:24 AM, Alexey Dokuchaev wrote: >>> On Tue, Dec 16, 2014 at 04:13:20PM +0200, Alex Kozlov wrote: >>>> On Tue, Dec 16, 2014 at 02:47:09PM +0100, Mathieu Arnold wrote: >>>>> +--On 16 d'ecembre 2014 15:38:02 +0200 Alex Kozlov <ak@FreeBSD.org>= wrote: >>>>> | Allow me to ask, why it should be 8 and not 4? >>>>> >>>>> Because a tabulation is 8 spaces. It should be consistent over the= whole >>>>> ports tree. >>>> >>>> Well, 'Please view me with 4 column tabs!' line was added to bsd.por= t.mk >>>> more than 20 year ago, in rev 69, because it's inconvenient to view = it with >>>> default tabulation value: many wrapped lines, indentation too deep, = etc. >>> >>> I think I agree with Alex here. While most of us prefer ts=3D8, I do= n't see >>> the need to reindent some files, most notably b.p.m., as it will comp= letely >>> jeopardize its history and make 'svn blame' basically useless. >>> >>> Even with editors that cannot grok ex:ts=3DX hints, its not that hard= to do it >>> manually every time you need to view/edit these files. I do it all t= he time >>> with nvi(1). >>> >>> ./danfe >>> >> >> As a vendor who maintains a forked ports tree, I despise this commit a= nd >> all of the ones below. It makes carrying out customizations very >> difficult. Yes, it doesn't *look* good on the eyes, but reindenting on= >> such large files with large history maintained by > 1 person is a sin.= >> >> r358259 | bapt | 2014-06-18 07:22:20 -0500 (Wed, 18 Jun 2014) | 2 line= s >> >> tabspace: 8 >> >> ----------------------------------------------------------------------= -- >> r358258 | bapt | 2014-06-18 07:21:35 -0500 (Wed, 18 Jun 2014) | 2 line= s >> >> tabspace: 8 >> >> ----------------------------------------------------------------------= -- >> r358255 | bapt | 2014-06-18 07:20:53 -0500 (Wed, 18 Jun 2014) | 2 line= s >> >> tabspace: 8 >> >> ----------------------------------------------------------------------= -- >> r358237 | bapt | 2014-06-18 04:43:38 -0500 (Wed, 18 Jun 2014) | 2 line= s >> >> tabspace: 8 >> >> ----------------------------------------------------------------------= -- >> r358236 | bapt | 2014-06-18 04:41:25 -0500 (Wed, 18 Jun 2014) | 2 line= s >> >> tabspace: 8 >> >> ----------------------------------------------------------------------= -- >> r358220 | bapt | 2014-06-18 02:30:24 -0500 (Wed, 18 Jun 2014) | 2 line= s >> >> tabspace: 8 >> >> ----------------------------------------------------------------------= -- >> r358219 | bapt | 2014-06-18 02:28:44 -0500 (Wed, 18 Jun 2014) | 2 line= s >> >> tabspace: 8 >> >> ----------------------------------------------------------------------= -- >> r358218 | bapt | 2014-06-18 02:26:25 -0500 (Wed, 18 Jun 2014) | 2 line= s >> >> tabspace: 8 >> >> ----------------------------------------------------------------------= -- >> r358217 | bapt | 2014-06-18 02:20:29 -0500 (Wed, 18 Jun 2014) | 2 line= s >> >> tabspace: 8 >> >> ----------------------------------------------------------------------= -- >> r358215 | bapt | 2014-06-18 02:17:13 -0500 (Wed, 18 Jun 2014) | 2 line= s >> >> Switch to tabspace: 8 >> >> ----------------------------------------------------------------------= -- >> r358214 | bapt | 2014-06-18 02:14:22 -0500 (Wed, 18 Jun 2014) | 2 line= s >> >> Switch to default tabspace: 8 >> ----------------------------------------------------------------------= -- >> r358213 | bapt | 2014-06-18 02:13:26 -0500 (Wed, 18 Jun 2014) | 2 line= s >> >> Switch back to default tabspace: 8 >> > Wow that makes impressive to quote that whole list of commits, among th= ose > changes a few are really changing things more than a few comments, and = most of > which are files that are either removed and/or heavily worked on at the= time, > there are yes 1 or 2 maybe controversial here but that is all. >=20 > Bapt >=20 They've been a pain point for me quite recently at work. --=20 Regards, Bryan Drewery --U786P4eRCA2JueUSxFN3cavqQUNBjQoTv Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (MingW32) iQEcBAEBAgAGBQJUkvf4AAoJEDXXcbtuRpfPdD8IAKykzutOWUoTbybLXwjKW84O A9w9jI9I70BbYrHkbaUwLrSiXGEef97CdygLl7gbk6eWiqYVMIYgqee+d01rFht+ g7vDMskwbe/kVE+bE7v9VbmH96cSWiiyfEL1F9UXIitDk/W+RpGznJVDP6SGS1DT ZzOQh9vDYpIXj6dy/jXE23VCIIE67y1I9atYpSviuwxKVsvqwzL6ejvKJd9H7RvZ XjZfXH1Lr+SGDw6Z6BCaJR4PmWhU/UvdIpfAO/+9n2CowW/jxfp1mWnLjADiFbM5 zO15OIqfyzfa+tiNX+K24CmV/YWKIuh5+YpmHI5ag7Yv1MuZzMxt6Uo+IoP7dz0= =Sn8e -----END PGP SIGNATURE----- --U786P4eRCA2JueUSxFN3cavqQUNBjQoTv--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5492F7F8.7080801>