From nobody Sat Apr 8 10:24:21 2023 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PtrvG6ZGdz44Glq; Sat, 8 Apr 2023 10:24:26 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: from mail-oa1-x34.google.com (mail-oa1-x34.google.com [IPv6:2001:4860:4864:20::34]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PtrvD1fZHz4LlW; Sat, 8 Apr 2023 10:24:24 +0000 (UTC) (envelope-from mjguzik@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-oa1-x34.google.com with SMTP id 586e51a60fabf-1841c57c221so3217939fac.3; Sat, 08 Apr 2023 03:24:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680949462; x=1683541462; h=content-transfer-encoding:cc:to:subject:message-id:date:from :references:in-reply-to:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Zk8RT3Tax+WVdP0OJhTag1owONtK6p08hZoxYbLL+EY=; b=bAb10uUEQoyWhr1Yll1OD292JcGgW57NMEvf0P+h5mAR66ryO/zkSH/vE/Pp3jOHVt yANXQxEyJr7x0OH7dPl/TPOOdFnAG/My1EdCuEEY7wGuBEmh/4jRY0ZiOc94O1u5m1rA wSuDCD11x7dtiGKIzAdqfAayMjvVZ+YLOOwgJ65THjmXa/fl9lea/SCkbZkV1H1Qb5vi gFlmhecDDvIoMKETp18mqQCLK5pUONdO/z3Ijbos2XWgG2aGVS2jUByOKqM/vSQPxB/d 3jQaGiCYDCtCanakzECiecuPASpWfD+sOWfJCDH+JVIuiWpCjLpRuH63f2y/X89WPKvp ryJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680949462; x=1683541462; h=content-transfer-encoding:cc:to:subject:message-id:date:from :references:in-reply-to:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Zk8RT3Tax+WVdP0OJhTag1owONtK6p08hZoxYbLL+EY=; b=Nx2cqtTObHFxEyUlKITAstaEL0XL71YiTh3mo81EyTyZ7OPgImVmxoFvb5D6fOKLI5 a4zPTxBk3LH5j0EidSSTeP/VJNJexwovHs3U1Ospk1m0w0prtJHb028pydcmjUYScwoj YkbZqlMsopOLkaEL+c4wDFiBhXtQQEPEjXCZf//6TgqK4FJH+awJBe0TkD2l4B5Zbe6p zmRsTSzendXeit6lgD81S2wCHcYv5fXBHtX6zZ9aQOvMTPherehWcsSiGK4Ae5uyyDo1 1ZkMH+Lo0hKbHy9FTlEyjNWw65mTvUWxgiLfsAOUuBatsh1+dWr8h8eYivEF6NhOejPK TFpg== X-Gm-Message-State: AAQBX9caZyveBEydb/kUE9aGoKWRV0K3mm0jPoHuDIBoi/HqduNtQcwD gbd4l6yCy5I56/1akTV1rTQzJs8wc0WLjS3sAduE4nQP X-Google-Smtp-Source: AKy350Zc1+gJznNaPGI30pPGDH6bDvfFE0ZkyskEf0m23OAfaObHp4RJCAcyfVTOj+GGRzywoSJEKqsuU3vzwVKAcao= X-Received: by 2002:a05:6870:12cf:b0:17a:b713:63e9 with SMTP id 15-20020a05687012cf00b0017ab71363e9mr826601oam.4.1680949462144; Sat, 08 Apr 2023 03:24:22 -0700 (PDT) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Received: by 2002:ac9:798d:0:b0:49c:b071:b1e3 with HTTP; Sat, 8 Apr 2023 03:24:21 -0700 (PDT) In-Reply-To: References: <3A019D10-E520-4C11-AE9F-4EA5D99B9B07@yahoo.com> From: Mateusz Guzik Date: Sat, 8 Apr 2023 12:24:21 +0200 Message-ID: Subject: Re: git: 2a58b312b62f - main - zfs: merge openzfs/zfs@431083f75 [separate aarch64 panic for zpool import] To: Kyle Evans Cc: Mark Millard , dev-commits-src-main@freebsd.org, Current FreeBSD , freebsd-arm , John F Carr Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 4PtrvD1fZHz4LlW X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2001:4860:4864::/48, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N On 4/8/23, Kyle Evans wrote: > On Fri, Apr 7, 2023 at 4:54=E2=80=AFPM Mateusz Guzik = wrote: >> >> On 4/7/23, Mark Millard wrote: >> > On Apr 7, 2023, at 14:26, Mateusz Guzik wrote: >> > >> >> On 4/7/23, Mateusz Guzik wrote: >> >>> can you try with this: >> >>> >> >>> diff --git >> >>> a/sys/contrib/openzfs/include/os/linux/kernel/linux/simd_aarch64.h >> >>> b/sys/contrib/openzfs/include/os/linux/kernel/linux/simd_aarch64.h >> >>> index 16276b08c759..e1bca9ef140a 100644 >> >>> --- >> >>> a/sys/contrib/openzfs/include/os/linux/kernel/linux/simd_aarch64.h >> >>> +++ >> >>> b/sys/contrib/openzfs/include/os/linux/kernel/linux/simd_aarch64.h >> >>> @@ -71,7 +71,7 @@ >> >>> #define ID_AA64PFR0_EL1 sys_reg(3, 0, 0, 1, 0) >> >>> #define ID_AA64ISAR0_EL1 sys_reg(3, 0, 0, 6, 0) >> >>> >> >>> -#define kfpu_allowed() 1 >> >>> +#define kfpu_allowed() 0 >> >>> #define kfpu_begin() kernel_neon_begin() >> >>> #define kfpu_end() kernel_neon_end() >> >>> #define kfpu_init() (0) >> >>> >> >>> >> >> >> >> ops, wrong file >> >> >> >> diff --git a/sys/contrib/openzfs/include/os/freebsd/spl/sys/simd_arm.= h >> >> b/sys/contrib/openzfs/include/os/freebsd/spl/sys/simd_arm.h >> >> index 178fbc3b3c6e..c462220289d6 100644 >> >> --- a/sys/contrib/openzfs/include/os/freebsd/spl/sys/simd_arm.h >> >> +++ b/sys/contrib/openzfs/include/os/freebsd/spl/sys/simd_arm.h >> >> @@ -46,7 +46,7 @@ >> >> #include >> >> #include >> >> >> >> -#define kfpu_allowed() 1 >> >> +#define kfpu_allowed() 0 >> >> #define kfpu_initialize(tsk) do {} while (0) >> >> #define kfpu_begin() do {} while (0) >> >> #define kfpu_end() do {} while (0) >> > >> > It will take me a bit to setup a separate build/install >> > context for the source code vintage involved. Then more >> > time to do the build, install, and test. (I'm keeping >> > my normal environments completely before the mess.) >> > >> > FYI: >> > >> > I have used the artifact build just after your pair of zfs >> > related updates to confirm the VFP problem is still in >> > place as of that point: >> > >> > https://artifact.ci.freebsd.org/snapshot/main/5e2e3615d91f9c0c68898791= 5ff5c8de23c22bde/arm64/aarch64/kernel.txz >> > >> > (No artifact build was exactly at either of your commits.) >> > >> > =3D=3D=3D >> > Mark Millard >> > marklmi at yahoo.com >> > >> > >> >> I have arm64 + zfs at $job and just verified the above lets it boot >> again, so I committed already. >> > > This was a known issue that we were working on fixing properly over in > https://reviews.freebsd.org/D39448... this really could have waited > just a little bit longer. This problem was already brought up in > response to the commit in question days ago. > Mate, that's one confusing email. I had seen the upstream review, apparently there is opposition to the patch, it is clearly not going to land within hours. Whatever the Real Fix(tm) might be, I'm confident my change has no impact on work on it, past the need to flip kfpu_allowed back to 1. At the same time things were broken to the point where aarch64 + zfs literally did not boot. Once more, I fail to see how restoring basic operation by fipping a macro to 0 throws any wrenches into the effort to get simd working. If anything the question is how come a clearly *not* implemented simd support got kfpu_allowed set to 1. --=20 Mateusz Guzik