From owner-svn-src-all@freebsd.org Thu Jun 22 14:08:59 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1ACA6D8D008; Thu, 22 Jun 2017 14:08:59 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pf0-x243.google.com (mail-pf0-x243.google.com [IPv6:2607:f8b0:400e:c00::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id DA6897C454; Thu, 22 Jun 2017 14:08:58 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pf0-x243.google.com with SMTP id y7so3124701pfd.3; Thu, 22 Jun 2017 07:08:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=1QyW2NkyjfvQuQuEZPQKfg6CG/4z3TNgnRXT+Pi80ic=; b=MKsi4jxtruvpCt8Hm0STWF6FkKcmNgGAvaq62YUuy3msZ5AifngxMI9nT3QHvVixX+ ZkMLS/URltP0vc4LKHXBzD59QI25K6g+HhE2jjiq8ME9FN3tf6F1s60ysYjXkq/uAkZf Pmkz2aya/tWrSNKaD3uwJGKLFZgBIRESpkY6Lo1PN9VqonttcOrOTDsvyyBm3lWhRLRc bkngiD/yj5HEpSV0tHQXAPwZbrcHj8SlTa83c32Lo9RsFVommYEf9AWaBMz9eNUN5qdj F1h+pGCLpa6NsaW1oE3S8E6K5vO1UvFlwt/R53JcAsEgjAZPuuFU4b/fGotFfppEfvnx lhJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=1QyW2NkyjfvQuQuEZPQKfg6CG/4z3TNgnRXT+Pi80ic=; b=SNj0zJ+rSaat/hlVuplTGDxoYSd7vrHuAyhH+3nSeqU5p6FBbZksLTAsDzaqm8uoiS ca0r/wyOyeX6Ot2ohQdLpbdINTnOLS31KjSrNNmkWxED9irdToK/HgaeVQH4fcNujlUb WDSKVEfMC5874TWz6NMFAASIh1jAsYgTUM7t7LAPFohtMhCfqFnFabdAUDC7utayvTc0 V0T5QgY6ieyWythA96HRI2PAU4aoTb3MZwHsZZoImq+syasE5g8AD9J6QPJ+x37jtzWN wAqxPQK7mE+iWdnAdCl+3oOW6ad3gabIrGZF0GP7Gb91Y4kiIv3442L7aUSafdya/VfT Z00Q== X-Gm-Message-State: AKS2vOzbpU2HfNB9bLD7WymsliU7ffV9rSsfC2yl06adian2h0/lWzT5 aGqvWQjcZneOYn2SlcA= X-Received: by 10.98.92.3 with SMTP id q3mr2793226pfb.65.1498140538023; Thu, 22 Jun 2017 07:08:58 -0700 (PDT) Received: from [192.168.20.13] (c-73-19-52-228.hsd1.wa.comcast.net. [73.19.52.228]) by smtp.gmail.com with ESMTPSA id o2sm4255665pgq.44.2017.06.22.07.08.56 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 22 Jun 2017 07:08:56 -0700 (PDT) Content-Type: text/plain; charset=cp932 Mime-Version: 1.0 (1.0) Subject: Re: svn commit: r320222 - in stable/10: etc etc/cron.d etc/mtree etc/newsyslog.conf.d etc/pam.d etc/syslog.d tools/build/mk usr.sbin/cron/cron usr.sbin/cron/lib usr.sbin/syslogd From: Ngie Cooper X-Mailer: iPhone Mail (14F89) In-Reply-To: Date: Thu, 22 Jun 2017 07:08:55 -0700 Cc: Ngie Cooper , src-committers , svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-10@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: <52481168-DCDD-4D6A-8F68-1EBDA44513D1@gmail.com> References: <201706220708.v5M78IYv080609@repo.freebsd.org> <223428BC-9035-4435-B8EB-9A72EDCDD225@gmail.com> To: John Baldwin X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Jun 2017 14:08:59 -0000 > On Jun 22, 2017, at 03:28, John Baldwin wrote: >=20 >> On 6/22/17 4:02 AM, Ngie Cooper (yaneurabeya) wrote: >>=20 >>> On Jun 22, 2017, at 00:35, John Baldwin wrote: >>=20 >> =81c >>=20 >>> Please revert the breakout of the existing config files. I think that s= plitting >>> up the conf files is too disruptive of a change (POLA) for stable branch= es. >>=20 >> Done in r320229 and r320230. >=20 > I haven't checked if this was merged to 11, but if so, I think they should= also > stay a single conf file in 11 for the same reason. No, it wasn't merged to 11, so no further action required here. >>> This was agreed to by other folks in the followup thread to the commits i= n >>> head that you continue to ignore. >>=20 >>=20 >>> In head please either fully split up the files or revert to a single fil= e >>> (another part of that thread you continue to ignore). >>=20 >> My eyes glazed over trying to read through all of the posts. I seem to= have missed the point where a proposed change was made to split up the conf= ig files further. Could this please be summarized again? >=20 > I think that having the files partially split up is the worst of both > worlds as folks writing config management rules, etc. have to use > different approaches depending on the rule. I think that is a headache > and would rather have the config either be all in a single file, or all > be split up into conf.d/ so that it is consistent. I also think that > when splitting up a conf file we should do it all at once so that there is= > only one painful /etc merge instead of several of them. This still doesn't answer my concern fully. In what way are the config files= in base not broken down 100%, i.e., what action can I take to resolve your c= oncerns about it not being fully modularized? I think syslog.conf having ker= beros.log is likely the last issue, but I would really like clarification in= order to move forward. If there isn't any actionable feedback here, I'll call what's done in head "= good enough", not MFC the changes, and move on to other pressing tasks. Thanks, -Ngie=