From owner-cvs-all  Mon May 18 13:55:52 1998
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Received: (from majordom@localhost)
          by hub.freebsd.org (8.8.8/8.8.8) id NAA01742
          for cvs-all-outgoing; Mon, 18 May 1998 13:55:52 -0700 (PDT)
          (envelope-from owner-cvs-all@FreeBSD.ORG)
Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.15.68.22])
          by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id NAA01568;
          Mon, 18 May 1998 13:55:20 -0700 (PDT)
          (envelope-from bde@godzilla.zeta.org.au)
Received: (from bde@localhost)
	by godzilla.zeta.org.au (8.8.7/8.8.7) id GAA30065;
	Tue, 19 May 1998 06:54:52 +1000
Date: Tue, 19 May 1998 06:54:52 +1000
From: Bruce Evans <bde@zeta.org.au>
Message-Id: <199805182054.GAA30065@godzilla.zeta.org.au>
To: guido@FreeBSD.ORG, jhay@mikom.csir.co.za
Subject: Re: cvs commit: src/sys/netinet tcp_input.c
Cc: cvs-committers@FreeBSD.ORG
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk

>> guido       1998/05/18 10:07:59 PDT
>> 
>>   Modified files:
>>     sys/netinet          tcp_input.c 
>>   Log:
>>   Add some parenthesis for clarity and fix a bug
>>   Pointed out by: Garrett Wollmand
>                                   ^
>Shouldn't you also add this to rc.network so that it can start
>automatically on new machines? :-)

Then you should also add the bd :-).  It deletes parentheses for
clarity.  Its review of this patch: "2 extra layers of parentheses
is 2 more layers than I would use and 1 more layer than KNF.  This
change has no affect on the object code.  Where is the bug fix?".

[The change was from `(foo & BAR && ...' to (((foo & BAR) != 0) && ...'.]

Bruce

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message