From owner-freebsd-ports@freebsd.org Thu Aug 9 05:06:24 2018 Return-Path: Delivered-To: freebsd-ports@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 07E971054D95 for ; Thu, 9 Aug 2018 05:06:24 +0000 (UTC) (envelope-from freebsd.ed.lists@sumeritec.com) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 90B11801A7 for ; Thu, 9 Aug 2018 05:06:23 +0000 (UTC) (envelope-from freebsd.ed.lists@sumeritec.com) Received: by mailman.ysv.freebsd.org (Postfix) id 5500A1054D94; Thu, 9 Aug 2018 05:06:23 +0000 (UTC) Delivered-To: ports@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 330A91054D92 for ; Thu, 9 Aug 2018 05:06:23 +0000 (UTC) (envelope-from freebsd.ed.lists@sumeritec.com) Received: from mx6-out9.antispamcloud.com (mx6-out9.antispamcloud.com [95.211.2.200]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id BE28B801A6 for ; Thu, 9 Aug 2018 05:06:22 +0000 (UTC) (envelope-from freebsd.ed.lists@sumeritec.com) Received: from [153.92.8.106] (helo=srv31.niagahoster.com) by mx63.antispamcloud.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89) (envelope-from ) id 1fnd9J-0007Cv-Fz for ports@freebsd.org; Thu, 09 Aug 2018 07:06:14 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sumeritec.com; s=default; h=Content-Transfer-Encoding:Content-Type: MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To:From:Date:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=ZSrHaneqwIvjDK+9YCV6kII1EGBqv9cV3vfhswyTIJo=; b=WfpIbS6xwtGd1Fxco3YM6U56e+ H+FKKkOCQnxkh10MX4NOgNq/9CMiRRp3NIwa9Lioj+VEpQEJGfRiJ37aan0SHViUPBGKUl34Bh24W TCWG9UxAmcsnJ5w19KruPqXmfrdjU1ZUUXAjL9Sxcvo3TwvH/07NG8fkwqiZZfX8Oms24ceg7M0Z5 7zdo8iQcluM9utaoIQw/to+v5JHLxt/qH8sWRW2IDTADI5pnpjH5unjC0SjLUBH1h9c6MltXHYICg vvkSI5qyTyJICsg484k1gYEWXnIr0+OoP22qQ1jY1ky3cUm8Em/5XawAgabxMIKkLilsD+ziK1vRE maPfRGOw==; Received: from [114.125.109.19] (port=47707 helo=X220.sumeritec.com) by srv31.niagahoster.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1fnd8P-00017C-9J; Thu, 09 Aug 2018 12:05:22 +0700 Date: Thu, 9 Aug 2018 13:05:14 +0800 From: Erich Dollansky To: Kubilay Kocak Cc: "ports@freebsd.org" , A.J.Caines@halplant.com Subject: Re: Blackbox does not compile, diff in here Message-ID: <20180809130514.1c0a6b22.freebsd.ed.lists@sumeritec.com> In-Reply-To: References: <20180809102943.3ab85fce.freebsd.ed.lists@sumeritec.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-OutGoing-Spam-Status: No, score=-1.0 X-AuthUser: freebsd.ed.lists@sumeritec.com X-Originating-IP: 153.92.8.106 X-AntiSpamCloud-Domain: out.niagahoster.com X-AntiSpamCloud-Username: niaga Authentication-Results: antispamcloud.com; auth=pass (login) smtp.auth=niaga@out.niagahoster.com X-AntiSpamCloud-Outgoing-Class: ham X-AntiSpamCloud-Outgoing-Evidence: SB/global_tokens (0.00462762739516) X-Recommended-Action: accept X-Filter-ID: EX5BVjFpneJeBchSMxfU5rr+2qzgi1Nw4n/h7yiguIF602E9L7XzfQH6nu9C/Fh9KJzpNe6xgvOx q3u0UDjvO/4EDnJ3EL7HIWDc6Pb6t074blWVt63bTPz1OgEBAYcNRLAVPQpVgLnA/WeFnznuayTg 127TqHZDxA/kZB41Rh901iU5yAsBk1OyzGhUzELBcaP9GnjkimbRb55BXxhZDzSkkFlQZz6yFr2K mBj9WjbWc+PIB7z0NFJh8FN10Ic641c/SimthgfOQipLVZUf64m3kXFxT3PHKpC8L4Stjnk9BNSM IeL844hdb5YC9oOas7rU/0aIzyPhsTjj9F2UjyYgheXjbkm4XOui1aD7jarMewWc1XbK1CdU42GV loYUXvDuFGkOuRGwqhSPI4i0mPBjHpXVtOBlF5TvPbH7W+s6rDn0tTOVcmJwqI8Ju2neb8/dDrnw 22i185WXA/1j12J+9fsbFgzfijVOmmeoxC8gnjA9lxFZz/HwHQOryIPXoGY2WKNFJZDNsFnHlKLi GtAeiVCVV1/QDfZe2XkUBYOCGXjYliqoNDdjiJJQObfarSOIPpeqwlm2NDGXIJ2x7HFkLRkMa8SM GWQeC2YKeJYXwVwfPNXdpzEG52BhwidvmgVkUr2nIgcAhm04huMd1afV2y7sOdPS0J5V39zAb1o+ n0GI+vic4IKyFWgs/C2Q92PNDpgLsd6Ddd/s7VM53tdnPuxFIxFtmUUsBociIOCX33GLwI1m6gEd XnHtln7HqsxxRE+2zQBlWxWdnj06b0FJc79DpEq2YQRAKE03tts4jN/S4o9FBZu25T8uQCnjBEaR RKhdpRMQVKdVTIgbnekBeesYDgIM1rkmRFMP2RbYu6+q1nkvGgiz27IHvQ4wJ4hvzMdfMIdvfTVQ 5z75sPLd14/y82ebPziYNS9mrGdRT5rWFD8BAm2aL++pZqMf9XDIPsBPTCfdnSebHjZ3wx83m8vf ZF7TvslswbOL+fk= X-Report-Abuse-To: spam@quarantine1.antispamcloud.com X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Aug 2018 05:06:24 -0000 Hi, On Thu, 9 Aug 2018 14:34:17 +1000 Kubilay Kocak wrote: > On 9/08/2018 12:29 pm, Erich Dollansky wrote: > > > > I do not know if somebody spotted this already. Some casting was > > done to the wrong types. > > This looks like > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=226708 > yes, it is the same. But why could I compile blackbox without a problem up to one or two months ago? Did the compiler to comprehend the problem before? Erich > The first and third chunks below appear to be > noise/spurious/unnecessary though. > > > Erich > > > > PS I am not experienced in creating diffs for ports. This one was > > done in the working directory's lib entry: > > > > > > --- EWMH.cc.180809 2005-01-24 > > 15:50:56.000000000 +0800 +++ EWMH.cc 2018-08-09 > > 10:10:05.630203000 +0800 @@ -204,7 +204,7 @@ > > bool bt::EWMH::readNumberOfDesktops(Window target, > > unsigned int* number) const { > > unsigned char* data = 0; > > - if (getProperty(target, XA_CARDINAL, net_number_of_desktops, > > &data)) { > > + if (getProperty (target, XA_CARDINAL, net_number_of_desktops, > > &data)) { *number = > > static_cast(*(reinterpret_cast > *>(data))); > > @@ -246,8 +246,11 @@ > > > > > > void bt::EWMH::setDesktopViewport(Window target, int x, int y) > > const { > > + // > > + // 09.08.18 ed: the following statement was modified. > > + // > > const unsigned long viewport[] = > > - { static_cast(x), static_cast(y) }; > > + { static_cast(x), static_cast > long>(y) }; setProperty(target, XA_CARDINAL, net_desktop_viewport, > > reinterpret_cast(viewport), > > 2); } > > @@ -644,8 +647,10 @@ > > } > > > > > > -bool bt::EWMH::getProperty(Window target, Atom type, Atom property, > > - unsigned char** data) const { > > +bool bt::EWMH::getProperty (Window target, Atom type, Atom > > property, > > + unsigned char ** data) > > const { Atom atom_return; > > int size; > > unsigned long nitems, bytes_left; > > _______________________________________________ > > freebsd-ports@freebsd.org mailing list > > https://lists.freebsd.org/mailman/listinfo/freebsd-ports > > To unsubscribe, send any mail to > > "freebsd-ports-unsubscribe@freebsd.org" >