From owner-svn-ports-head@freebsd.org Tue Oct 20 16:01:58 2015 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0C403A198F8; Tue, 20 Oct 2015 16:01:58 +0000 (UTC) (envelope-from lars@e-new.0x20.net) Received: from mail.0x20.net (mail.0x20.net [IPv6:2001:aa8:fffb:1::3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.0x20.net", Issuer "mail.0x20.net" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 98D1229C; Tue, 20 Oct 2015 16:01:57 +0000 (UTC) (envelope-from lars@e-new.0x20.net) Received: from e-new.0x20.net (mail.0x20.net [IPv6:2001:aa8:fffb:1::3]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by mail.0x20.net (Postfix) with ESMTPS id A11166E005D; Tue, 20 Oct 2015 18:01:54 +0200 (CEST) Received: from e-new.0x20.net (localhost [127.0.0.1]) by e-new.0x20.net (8.14.7/8.14.7) with ESMTP id t9KG1sUv072170; Tue, 20 Oct 2015 18:01:54 +0200 (CEST) (envelope-from lars@e-new.0x20.net) Received: (from lars@localhost) by e-new.0x20.net (8.14.7/8.14.7/Submit) id t9KG1rlv070779; Tue, 20 Oct 2015 18:01:53 +0200 (CEST) (envelope-from lars) Date: Tue, 20 Oct 2015 18:01:53 +0200 From: Lars Engels To: Mathieu Arnold Cc: Jan Beich , Lars Engels , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r399705 - head/net-mgmt/aircrack-ng Message-ID: <20151020160153.GI66179@e-new.0x20.net> References: <201510191805.t9JI5mEP085148@repo.freebsd.org> <7D8DC2B6B35EA3356CFE4530@atuin.in.mat.cc> <20151020131452.GH66179@e-new.0x20.net> <566D251D429BE229A8507878@ogg.in.absolight.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="r4QXMf6/kyF/FvJJ" Content-Disposition: inline In-Reply-To: <566D251D429BE229A8507878@ogg.in.absolight.net> X-Editor: VIM - Vi IMproved 7.4 X-Operation-System: FreeBSD 8.4-RELEASE-p23 User-Agent: Mutt/1.5.23 (2014-03-12) X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Oct 2015 16:01:58 -0000 --r4QXMf6/kyF/FvJJ Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Oct 20, 2015 at 03:28:12PM +0200, Mathieu Arnold wrote: > +--On 20 octobre 2015 15:14:52 +0200 Lars Engels > wrote: > | On Tue, Oct 20, 2015 at 11:26:00AM +0200, Mathieu Arnold wrote: > |>=20 > |>=20 > |> +--On 19 octobre 2015 20:33:35 +0200 Jan Beich > |> wrote: > |> | Lars Engels writes: > |> |=20 > |> |> +INSTALL_TARGET=3D strip install > |> | [...] > |> |> -post-install: > |> |> - @${STRIP_CMD} ${BIN_FILES:S,^,${STAGEDIR}${PREFIX}/bin/,} \ > |> |> - ${SBIN_FILES:S,^,${STAGEDIR}${PREFIX}/sbin/,} > |> |=20 > |> | This always strips the binaries, even for WITH_DEBUG=3D1. The magic = for > |> | INSTALL_TARGET in bsd.port.mk only works with default automake targe= t. > |> |=20 > |> | Index: net-mgmt/aircrack-ng/Makefile > |> | =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > |> | --- net-mgmt/aircrack-ng/Makefile (revision 399707) > |> | +++ net-mgmt/aircrack-ng/Makefile (working copy) > |> | @@ -18,7 +18,7 @@ CPE_VERSION=3D ${DISTVERSION:C/-.*//} > |> | CPE_UPDATE=3D ${DISTVERSION:C/^[^-]*$//:C/.*-//} > |> | DOS2UNIX_FILES=3D src/osdep/byteorder.h > |> | MAKE_ARGS=3D experimental=3Dtrue libnl=3Dfalse prefix=3D${PREFIX} > |> | -INSTALL_TARGET=3D strip install > |> | +INSTALL_TARGET=3D ${STRIP:S/-s/strip/} install > |> | USE_OPENSSL=3D yes > |> | =20 > |> | OPTIONS_DEFINE=3D PCRE SQLITE > |>=20 > |=20 > | Thanks Jan, I didn't think about this. > |=20 > |=20 > |> This is harder to understand, if you don't know what STRIP is for, or > |> what it contains, it does not make a lot of sense, the previous way was > |> better, I feel. > |=20 > | I think I'll just add a comment what Jan's solution to this problem > | does. > | The way it was before was clumy, because I had to add [S]BIN_FILES > | variables containing all (often changing) binaries. >=20 > You could also have run ${STRIP_CMD} ${STAGEDIR}${PREFIX}/*bin/* or > something similar where you did not need to maintain that list :-) No, unfortunately there are also shell scripts along "real" binaries in those directories. --r4QXMf6/kyF/FvJJ Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQF8BAEBCgBmBQJWJmVxXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQ4RjQwMDE3RTRERjUzMTI1N0FGRTUxNDlF NTRDQjM3RDNBMDg5RDZEAAoJEOVMs306CJ1t0XIH/j9SlTrPmHlNppoNd7wudLvV K02YiFoYvGz3gLFWS++akRewkUGFSh1dsbB2myq9fR/485QdgORfR8guHgkQ9YZ2 e/H14sgfmqhSPfk3Ul03xEe0GIuyYq/eQQyKnu/kiFuq176nenpy9y3hupObeobU PwTWlDI1mlLTEN1j5M1cgegXSdb3xMmko4g++HK/7cKEgO+I61xq/jg/epQnt2Hv XtNLqpfGRt0ImUA9+FakXAkGEFW4ONh5Cdkw6H9VT62zD4Li+lwNFPAQpryd9IcI SMUznrWCbFDFQu/9n9lxfh6KXahe8Q7PW6tBsss8uP1yVpI1heVMtDcbqcc/c64= =QM8S -----END PGP SIGNATURE----- --r4QXMf6/kyF/FvJJ--