From owner-freebsd-arch@FreeBSD.ORG Fri Jan 13 18:02:16 2006 Return-Path: X-Original-To: arch@FreeBSD.org Delivered-To: freebsd-arch@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5372D16A41F; Fri, 13 Jan 2006 18:02:16 +0000 (GMT) (envelope-from glebius@FreeBSD.org) Received: from cell.sick.ru (cell.sick.ru [217.72.144.68]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8F03B43D46; Fri, 13 Jan 2006 18:02:15 +0000 (GMT) (envelope-from glebius@FreeBSD.org) Received: from cell.sick.ru (glebius@localhost [127.0.0.1]) by cell.sick.ru (8.13.3/8.13.3) with ESMTP id k0DI2Dva000207 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 13 Jan 2006 21:02:14 +0300 (MSK) (envelope-from glebius@FreeBSD.org) Received: (from glebius@localhost) by cell.sick.ru (8.13.3/8.13.1/Submit) id k0DI2DsK000206; Fri, 13 Jan 2006 21:02:13 +0300 (MSK) (envelope-from glebius@FreeBSD.org) X-Authentication-Warning: cell.sick.ru: glebius set sender to glebius@FreeBSD.org using -f Date: Fri, 13 Jan 2006 21:02:13 +0300 From: Gleb Smirnoff To: Xin LI Message-ID: <20060113180213.GH83922@cell.sick.ru> References: <20060113170552.GF83922@FreeBSD.org> <20060113171759.GA1255@hub.freebsd.org> <20060113172049.GG83922@cell.sick.ru> <20060113175212.GA4170@hub.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline In-Reply-To: <20060113175212.GA4170@hub.freebsd.org> User-Agent: Mutt/1.5.6i Cc: arch@FreeBSD.org, re@FreeBSD.org Subject: Re: review: patch to restore VLAN kernel API in RELENG_6 X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Jan 2006 18:02:16 -0000 On Fri, Jan 13, 2006 at 05:52:12PM +0000, Xin LI wrote: X> On Fri, Jan 13, 2006 at 08:20:49PM +0300, Gleb Smirnoff wrote: X> > On Fri, Jan 13, 2006 at 05:17:59PM +0000, Xin LI wrote: X> > X> > +++ sys/dev/bge/if_bge.c 13 Jan 2006 17:04:31 -0000 X> > X> > @@ -2862,7 +2862,7 @@ X> > X> > * attach that information to the packet. X> > X> > */ X> > X> > if (have_tag) { X> > X> > - VLAN_INPUT_TAG(ifp, m, vlan_tag); X> > X> > + VLAN_INPUT_TAG_NEW(ifp, m, vlan_tag); X> > X> X> > X> What if "VLAN_INPUT_TAG_2" or something with numerical name? X> > X> X> > X> Just my $0.02, though :-) X> > X> > I really don't care. :) X> X> Heh, my point was to make it possible to use the same name in X> both drivers on RELENG_6 and 7.0, without having to call future X> macros "foo_NEW_NG" or so =-) Not really sure whether it is X> conform to our tradition naming, though... The correct macro takes 3 arguments, and the old one took 4. So we can't make a code compilable with correct macro on both systems without breaking API - using same macro. -- Totus tuus, Glebius. GLEBIUS-RIPN GLEB-RIPE