From owner-freebsd-current@freebsd.org Fri Nov 20 22:41:11 2015 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 72110A34C23 for ; Fri, 20 Nov 2015 22:41:11 +0000 (UTC) (envelope-from truckman@FreeBSD.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 5EAE114CE for ; Fri, 20 Nov 2015 22:41:11 +0000 (UTC) (envelope-from truckman@FreeBSD.org) Received: by mailman.ysv.freebsd.org (Postfix) id 5B682A34C21; Fri, 20 Nov 2015 22:41:11 +0000 (UTC) Delivered-To: current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5AE0AA34C20; Fri, 20 Nov 2015 22:41:11 +0000 (UTC) (envelope-from truckman@FreeBSD.org) Received: from gw.catspoiler.org (unknown [IPv6:2602:304:b010:ef20::f2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "gw.catspoiler.org", Issuer "gw.catspoiler.org" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 38BF514CA; Fri, 20 Nov 2015 22:41:11 +0000 (UTC) (envelope-from truckman@FreeBSD.org) Received: from FreeBSD.org (mousie.catspoiler.org [192.168.101.2]) by gw.catspoiler.org (8.15.2/8.15.2) with ESMTP id tAKMf1KS086433; Fri, 20 Nov 2015 14:41:05 -0800 (PST) (envelope-from truckman@FreeBSD.org) Message-Id: <201511202241.tAKMf1KS086433@gw.catspoiler.org> Date: Fri, 20 Nov 2015 14:41:01 -0800 (PST) From: Don Lewis Subject: Re: CAM Shingled Disk support patches available To: ken@FreeBSD.ORG cc: fullermd@over-yonder.net, current@freebsd.org, scsi@freebsd.org In-Reply-To: <20151119202942.GA25213@mithlond.kdm.org> MIME-Version: 1.0 Content-Type: TEXT/plain; charset=us-ascii X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Nov 2015 22:41:11 -0000 On 19 Nov, Kenneth D. Merry wrote: > On Thu, Nov 19, 2015 at 12:48:41 -0600, Matthew D. Fuller wrote: >> On Wed, Nov 18, 2015 at 12:13:09PM -0500 I heard the voice of >> Kenneth D. Merry, and lo! it spake thus: >> > >> > Testing and comments are welcome. >> >> GELI does explicit handling of each BIO type, so will need to be >> updated to pass it through (possibly in the form of inverting the >> default handling?) or it'll just EOPNOTSUPP it, whether the underlying >> layer does or not. I wouldn't be surprised if there were other geom >> layers that did similar things. >> >> Not meant to be read as some kind of "you need to"; just a comment on >> a possible [lack of] impact. > > You're correct. For GEOM classes like GELI that don't change the layout on > disk, passing the BIO_ZONE bio through would be the right thing to do. > > For those that change the layout (i.e. the lba you write on the virtual > disk doesn't match what goes down to the physical disk), like graid or partitioning or > gstripe, I think all we really need to do is just make sure they return > EOPNOTSUPP. If someone wants to modify that code to handle shingled disks, > they can certainly do that. > > Ken