From owner-svn-src-head@freebsd.org Mon May 27 22:47:15 2019 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5711615AD1F1; Mon, 27 May 2019 22:47:15 +0000 (UTC) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: from gndrsh.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id C617A8A169; Mon, 27 May 2019 22:47:14 +0000 (UTC) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: from gndrsh.dnsmgr.net (localhost [127.0.0.1]) by gndrsh.dnsmgr.net (8.13.3/8.13.3) with ESMTP id x4RMlB5j012882; Mon, 27 May 2019 15:47:11 -0700 (PDT) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: (from freebsd@localhost) by gndrsh.dnsmgr.net (8.13.3/8.13.3/Submit) id x4RMlBer012881; Mon, 27 May 2019 15:47:11 -0700 (PDT) (envelope-from freebsd) From: "Rodney W. Grimes" Message-Id: <201905272247.x4RMlBer012881@gndrsh.dnsmgr.net> Subject: Re: svn commit: r232071 - head/sys/vm In-Reply-To: To: Ian Lepore Date: Mon, 27 May 2019 15:47:11 -0700 (PDT) CC: rgrimes@freebsd.org, Alexey Dokuchaev , Konstantin Belousov , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Reply-To: rgrimes@freebsd.org X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: C617A8A169 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.95 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.95)[-0.946,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 May 2019 22:47:15 -0000 > On Mon, 2019-05-27 at 14:34 -0700, Rodney W. Grimes wrote: > > I just ask that before a change be made that starts from some > > static analysis tool that a formal code review occur before > > the change is committed. > > In a word: No. > > We're not talking about some inexperienced coder committing dumb fixes > to silence warnings here. In this specific instance perhaps not so, but unless I am miss remebering the thread either a change was suggested that came from a static analysis tool that an area expert vetoed. That is ineffect what I advocated, so you can say No, but that is not what actually occurred. Furthermore we have had "inexperienced coder's" commit dumb fixes to silence a wwarning that later had to be reverted and cleaned up properly. So again, you can say No, but your basis is wrong. > What I've seen so far is that fixes are > being committed by the people who originally wrote or currently > maintain the code in question. Nothing bad is happening, so nothing > about the process needs to be fixed or changed in any way. This is not what is going on. > Process for process' sake is just obstruction. This is not process for process sake, this is process to stop bad code changes, and you can not say it is not happening, because it is. > -- Ian -- Rod Grimes rgrimes@freebsd.org