From owner-freebsd-current@FreeBSD.ORG Sat Dec 24 01:50:17 2011 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 61323106566B for ; Sat, 24 Dec 2011 01:50:17 +0000 (UTC) (envelope-from kabaev@gmail.com) Received: from mail-qy0-f182.google.com (mail-qy0-f182.google.com [209.85.216.182]) by mx1.freebsd.org (Postfix) with ESMTP id 1AEBA8FC08 for ; Sat, 24 Dec 2011 01:50:16 +0000 (UTC) Received: by qcse13 with SMTP id e13so8850960qcs.13 for ; Fri, 23 Dec 2011 17:50:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:in-reply-to:references:x-mailer :mime-version:content-type; bh=O2fqFWUGJi6n6LZYtF1tAoaXoehosj5d2Mi1iHGesF8=; b=bNqiRnGMfUGCS77Ua6lSwBMeu1WJ34CKQTmQZ8R4FWR8zbgnZmZ+Yweb8JwQQilIAV K26ftXpfCboOkKo0BGcm4b1fHaqbchISX3LvisPcEF0m5dZKMNJZJsSyZZCtPeph1CQv RFJVZ7NEhoDEHz9+Bj+tFlzYOQbwBNWjj4EJQ= Received: by 10.229.78.216 with SMTP id m24mr6500602qck.34.1324691415590; Fri, 23 Dec 2011 17:50:15 -0800 (PST) Received: from kan.dyndns.org (c-24-63-226-98.hsd1.ma.comcast.net. [24.63.226.98]) by mx.google.com with ESMTPS id i10sm27717478qac.17.2011.12.23.17.50.13 (version=SSLv3 cipher=OTHER); Fri, 23 Dec 2011 17:50:14 -0800 (PST) Date: Fri, 23 Dec 2011 20:50:07 -0500 From: Alexander Kabaev To: Erik Cederstrand Message-ID: <20111223205007.16eb27c5@kan.dyndns.org> In-Reply-To: References: X-Mailer: Claws Mail 3.7.10 (GTK+ 2.24.6; amd64-portbld-freebsd9.0) Mime-Version: 1.0 Content-Type: multipart/signed; micalg=PGP-SHA1; boundary="Sig_/ztyrywUZZxS271OCdvd7=Qn"; protocol="application/pgp-signature" Cc: FreeBSD Current Subject: Re: GCC debug flags cleanup X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 24 Dec 2011 01:50:17 -0000 --Sig_/ztyrywUZZxS271OCdvd7=Qn Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Thu, 22 Dec 2011 12:52:45 +0100 Erik Cederstrand wrote: > Hi, >=20 > I've created a patch that cleans up FreeBSD Makefiles that > unconditionally set the -g flag for GCC. The motivation for this is > that it should be possible to add or remove this flag globally via > e.g. CFLAGS (it's part of my quest to produce deterministic builds). >=20 > I'm not very familiar with GCC or the build infrastructure, so I'd be > grateful if someone would review it and possibly commit. >=20 > http://dev.affect-it.dk/gcc_debug_flags.diff >=20 > Thanks, > Erik_______________________________________________ gnu/usr.bin/cc/cc_tools/Makefile just builds tools that are used for building gcc itself and are non installed anywhere outside of $OBJDIR. I doubt disabling -g there buys you much, but having it there is also of questionable value. Verdict: could not care less either way. All of the gcc/contrib changes are useless - we are not using any of stock Makefiles. sys/amd64/conf/GENERIC - please understang _why_ it is there before you remove it. When you do, you will probably will drop the idea. -- Alexander Kabaev --Sig_/ztyrywUZZxS271OCdvd7=Qn Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.18 (FreeBSD) iD8DBQFO9S/UQ6z1jMm+XZYRAlx7AKC7vT3F4MUp67Zvnr/n5qEKZMEX5ACgqnNK csnj4zYsHkUWfMshk5qkH7Y= =VVOB -----END PGP SIGNATURE----- --Sig_/ztyrywUZZxS271OCdvd7=Qn--