From owner-freebsd-drivers@FreeBSD.ORG Fri May 13 01:40:57 2011 Return-Path: Delivered-To: freebsd-drivers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4B9F9106564A; Fri, 13 May 2011 01:40:57 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id 19BFF8FC08; Fri, 13 May 2011 01:40:57 +0000 (UTC) Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net [66.111.2.69]) by cyrus.watson.org (Postfix) with ESMTPSA id 9CF2146B2C; Thu, 12 May 2011 21:40:56 -0400 (EDT) Received: from John-Baldwins-Macbook-Pro.local (unknown [24.114.252.233]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id E786E8A01B; Thu, 12 May 2011 21:40:55 -0400 (EDT) Message-ID: <4DCC8C27.2010605@FreeBSD.org> Date: Thu, 12 May 2011 21:40:55 -0400 From: John Baldwin User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.2.17) Gecko/20110414 Thunderbird/3.1.10 MIME-Version: 1.0 To: Henrik Brix Andersen References: <3550EA55-ADDE-40AC-9C22-1FAC441A0BC8@freebsd.org> <0A707516-C7D1-4441-B17B-1273B6C256B0@FreeBSD.org> <201103141028.57324.jhb@freebsd.org> <87F8ACF6-822B-41E3-B832-890F7F68ABA2@FreeBSD.org> In-Reply-To: <87F8ACF6-822B-41E3-B832-890F7F68ABA2@FreeBSD.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.6 (bigwig.baldwin.cx); Thu, 12 May 2011 21:40:56 -0400 (EDT) Cc: freebsd-drivers@freebsd.org Subject: Re: Allocating resources to isab children X-BeenThere: freebsd-drivers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Writing device drivers for FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 May 2011 01:40:57 -0000 On 5/12/11 5:45 PM, Henrik Brix Andersen wrote: > Hi John, > > On Mar 14, 2011, at 15:28, John Baldwin wrote: >> On Sunday, March 13, 2011 12:12:59 pm Henrik Brix Andersen wrote: >>> On Mar 12, 2011, at 20:47, Henrik Brix Andersen wrote: >>> I have a patch ready for allowing the PCI-ISA bridge to proxy SYS_RES_MEMORY >> and SYS_RES_IOPORT resource allocations from direct children to the parent PCI >> bus. >>> The patch is available from here: http://people.freebsd.org/~brix/src- >> patches/isa_pci.c.diff >> >> Yes, I think this looks good. > > Having completed the driver for the I2C host bus controller, I have revised the patch a little. > The updated patch is available at http://people.freebsd.org/~brix/src-patches/isa_pci.c.diff A few cosmetic nits: - I would use 'isab_pci_*' rather than 'isa_pci_*' as it is an ISA bridge rather than an ISA bus device. - You can probably leave out the blank line in isa[b]_pci_attach() between bus_generic_probe() and isab_attach(). Other than that, you are fine to commit this with a reviewed by from me. > I would appreciate it if you could find the time to review this and - if possible - approve a commit of this patch. > > The patch for the glxiic(4) I2C host bus driver is available at http://people.freebsd.org/~brix/src-patches/glxiic.diff - if somebody could find the time to review this as well, I would be very grateful. Since I do not have a commit bit for src, I will eventually need an approval for this to enter the tree as well. This mostly looks good to me. I can't evaluate the actual driver logic, but the new-bus, etc. bits look fine. One thing is that since you use callout_init_mtx(), I don't think you need any of the callout stuff at the start of your timeout routine (callout_pending/active/deactivate). With callout_init_mtx() your callout will only be called if it is active. That is the only nit that I saw however. -- John Baldwin