From owner-freebsd-python@FreeBSD.ORG Thu May 21 02:05:11 2015 Return-Path: Delivered-To: freebsd-python@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 78AB2544 for ; Thu, 21 May 2015 02:05:11 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4320718A8 for ; Thu, 21 May 2015 02:05:11 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t4L25A2X072641 for ; Thu, 21 May 2015 02:05:10 GMT (envelope-from daemon-user@phabric-backend.isc.freebsd.org) Received: (from daemon-user@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t4L25AJQ072640; Thu, 21 May 2015 02:05:10 GMT (envelope-from daemon-user) Date: Thu, 21 May 2015 02:05:10 +0000 To: freebsd-python@freebsd.org From: "koobs (Kubilay Kocak)" Subject: [Differential] [Requested Changes To] D2600: [new port] devel/py-pytest-timeout Message-ID: <1c62e4264e256d609fbe8bb04b3fb83b@localhost.localdomain> X-Priority: 3 Thread-Topic: D2600: [new port] devel/py-pytest-timeout X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: ZmNiMGY0ZDVhMDYzOWM4NzhlY2IyNDIwOTc5IFVdPVY= Precedence: bulk X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , , MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-python@freebsd.org X-Mailman-Version: 2.1.20 List-Id: FreeBSD-specific Python issues List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 May 2015 02:05:11 -0000 koobs requested changes to this revision. koobs added a comment. This revision now requires changes to proceed. Additional to inline comments, does the port also pass poudriere and portlint -AC (with DEVELOPER=yes enabled in /etc/make.conf) ? INLINE COMMENTS devel/py-pytest-timeout/Makefile:16 Upstream install_requires (setup.py) field says: ``` install_requires=['pytest>=2.6.3.dev3'], ``` I would change this entry to ``` pytest>=2.6.4 ``` which is the current Ports version of py-pytest devel/py-pytest-timeout/pkg-descr:1 Upstream long_description (setup.py) contains: ``` This is a plugin which will terminate tests after a certain timeout. When doing so it will show a stack dump of all threads running at the time. This is useful when running tests under a continuous integration server or simply if you don't know why the test suite hangs. ``` This seems like a more complete/meaningful description than just a copy of COMMENT from Makefile devel/py-pytest-timeout/pkg-descr:3 Upstream URL (setup.py) field contains: ``` https://bitbucket.org/flub/pytest-timeout ``` REPOSITORY rP FreeBSD ports repository REVISION DETAIL https://reviews.freebsd.org/D2600 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: loader, koobs Cc: freebsd-python