From owner-freebsd-net  Thu Oct  3  8:58:11 2002
Delivered-To: freebsd-net@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 16C2137B404; Thu,  3 Oct 2002 08:58:10 -0700 (PDT)
Received: from wall.polstra.com (wall-gw.polstra.com [206.213.73.130])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 2229343E3B; Thu,  3 Oct 2002 08:58:09 -0700 (PDT)
	(envelope-from jdp@polstra.com)
Received: from vashon.polstra.com (vashon.polstra.com [206.213.73.13])
	by wall.polstra.com (8.11.3/8.11.3) with ESMTP id g93Fw8x17832;
	Thu, 3 Oct 2002 08:58:08 -0700 (PDT)
	(envelope-from jdp@vashon.polstra.com)
Received: (from jdp@localhost)
	by vashon.polstra.com (8.12.5/8.12.5/Submit) id g93Fw8ER001397;
	Thu, 3 Oct 2002 08:58:08 -0700 (PDT)
	(envelope-from jdp)
Date: Thu, 3 Oct 2002 08:58:08 -0700 (PDT)
Message-Id: <200210031558.g93Fw8ER001397@vashon.polstra.com>
To: net@freebsd.org
From: John Polstra <jdp@polstra.com>
Cc: rwatson@freebsd.org
Subject: Re: NFS client code calls sosend() directly...
In-Reply-To: <Pine.NEB.3.96L.1021002161746.46964K-100000@fledge.watson.org>
References: <Pine.NEB.3.96L.1021002161746.46964K-100000@fledge.watson.org>
Organization: Polstra & Co., Seattle, WA
Sender: owner-freebsd-net@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-net.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-net>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-net>
X-Loop: FreeBSD.org

In article <Pine.NEB.3.96L.1021002161746.46964K-100000@fledge.watson.org>,
Robert Watson  <rwatson@FreeBSD.ORG> wrote:
> On Wed, 2 Oct 2002, Garrett Wollman wrote:
> 
> > <<On Wed, 2 Oct 2002 14:26:49 -0400 (EDT), Robert Watson <rwatson@FreeBSD.org> said:
> > 
> > > protocols have the option of implementing pru_sosend() using the central
> > > sosend(), or providing their own optimized implementation.  However, the
> > > exception to this appears to be in the nfsclient code, where sosend is
> > > invoked directly on the socket:
> > 
> > The NFS code is hairy and evil and since I don't use it I didn't want to
> > touch it when I made that change several years ago. 
> 
> I guess my question then is: I'd like to clean this up.  Is the approach
> I'm suggesting correct?

FWIW, your approach is what the ng_ksocket node does.  I've used it
before and it worked fine for me.

John
-- 
  John Polstra
  John D. Polstra & Co., Inc.                        Seattle, Washington USA
  "Disappointment is a good sign of basic intelligence."  -- Chögyam Trungpa


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-net" in the body of the message