From owner-freebsd-emulation@FreeBSD.ORG  Sat Nov 24 22:37:38 2007
Return-Path: <owner-freebsd-emulation@FreeBSD.ORG>
Delivered-To: emulation@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 5159C16A419;
	Sat, 24 Nov 2007 22:37:38 +0000 (UTC)
	(envelope-from rdivacky@vlk.vlakno.cz)
Received: from vlakno.cz (vlk.vlakno.cz [62.168.28.247])
	by mx1.freebsd.org (Postfix) with ESMTP id 0119813C459;
	Sat, 24 Nov 2007 22:37:37 +0000 (UTC)
	(envelope-from rdivacky@vlk.vlakno.cz)
Received: from localhost (localhost [127.0.0.1])
	by vlakno.cz (Postfix) with ESMTP id 3CEE166A402;
	Sat, 24 Nov 2007 23:19:48 +0100 (CET)
X-Virus-Scanned: amavisd-new at vlakno.cz
Received: from vlakno.cz ([127.0.0.1])
	by localhost (vlk.vlakno.cz [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id T1C6GNQKl5Aq; Sat, 24 Nov 2007 23:19:47 +0100 (CET)
Received: from vlk.vlakno.cz (localhost [127.0.0.1])
	by vlakno.cz (Postfix) with ESMTP id 0184366A3EE;
	Sat, 24 Nov 2007 23:19:46 +0100 (CET)
Received: (from rdivacky@localhost)
	by vlk.vlakno.cz (8.13.8/8.13.8/Submit) id lAOMJkou074694;
	Sat, 24 Nov 2007 23:19:46 +0100 (CET) (envelope-from rdivacky)
Date: Sat, 24 Nov 2007 23:19:46 +0100
From: Roman Divacky <rdivacky@freebsd.org>
To: emulation@freebsd.org
Message-ID: <20071124221946.GA74651@freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.4.2.3i
Cc: des@freebsd.org
Subject: compat/linprocfs
X-BeenThere: freebsd-emulation@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Development of Emulators of other operating systems
	<freebsd-emulation.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-emulation>, 
	<mailto:freebsd-emulation-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-emulation>
List-Post: <mailto:freebsd-emulation@freebsd.org>
List-Help: <mailto:freebsd-emulation-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-emulation>, 
	<mailto:freebsd-emulation-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 24 Nov 2007 22:37:38 -0000

hi

in
compat/linprocfs/linprocfs.c:linprocfs_doprocmaps() there's 

        unsigned int last_timestamp;

variable declaration, this variable is used only once in this function:

        if (last_timestamp + 1 != map->timestamp) {

ie. the map->timestamp is compared to some stack garbage + 1. this does not
seem to be correct, the last_timestamp must be set somewhere..

comments?

roman