From nobody Thu Dec 11 09:25:57 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4dRnJP4cKYz6Kf74 for ; Thu, 11 Dec 2025 09:25:57 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4dRnJP296Zz3fCS for ; Thu, 11 Dec 2025 09:25:57 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1765445157; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=p6diJrvk+N7kaJg/3CDbFNgzumMMdRJGPwo/nxZIfbc=; b=VmF7hcDR7ha/574+g5G3qq2fHjM+NkiMMORmGKRHcbzNApWofIc5KWoger+W5np4bbLrhP yjauUtPsjBw3KEYZGcyueie4sMq+KrRkhU6+lsq01Q4xZgiP6uNuvXOiuIStyRspuGg2tl QPS2eF0wSrn10B9xwXq//pwEcFdNZYAsasM3DpTcF+u+i5ec2cqli0FKQoDJb5kRhhsch0 CPUURoD2e3GDT0tcpahMMyxJgkrnjbYo55GaiSnDqb6Ziq3xoSvASITmAqlpM5fQY+ZO7I nuqd8CWLj+NhmiGPtuVuhPAJEgFr2aCkp0zzF4uBxor8Vl6cBNjlR5Vy1LEzRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1765445157; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=p6diJrvk+N7kaJg/3CDbFNgzumMMdRJGPwo/nxZIfbc=; b=Ig3x1K2gcRQQZIXRFS7AkaReMKvCS8i06CZ9/O3GWhOXE9RABSunh7f937T1e9LLVLp++p B+ftiTbskdhQA1hWTIaTiQoETwKyDr3esYHA12huEUF94mLnO1ShDNktKMUxDUE9417b4C RX6hMpqif2T+L2I7LLSRBOGKBh5CTNCfFFSH/PlUzWsJujHxxVEAmU5dp2BznCuOj38766 i3zdvbQYA/iq1zG/mYezX+N/wMGHq/5a9PLsLhCQyQPSgoD/aLyoSe9dURad2LLK+HCaRp sBWWXu+F3g5YDtFXqPqZJp26lspaJ6cjrgl9vg+RuJQfswAm1W0fpMOp5sU+Lw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1765445157; a=rsa-sha256; cv=none; b=Uuu2QfV3ncFX50IACndHZ5HL7nvMO5giK/RL2O0aItHBv2aSSLKnjPmsrVK/Rhy9LuhEKP KrquumtXPwhK5IbjFvXUoRgzqyyG8OiZmxKaLI4iqaq9to5uDJUl0kczn1jTIXvd5/Keed miv0jQk/sPi0Byh8fmmyLDXovOucKQURuc4hqoK6HfgjUwRY7Kc49qFnDt+Cs32kegg4Ex C+0nQYdhubfOSCoIlIitfGQylyXzQtl8tZ7rsPD3Cb9QywEtxrQqNCxwaDrt0ncKypOPIJ AHzd5ObMORpTVdlaWcvq10LiURWpBk/GwVrlStGjDgcnkAhTsty2gnvP+WPYlw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4dRnJP1SmWz9Ks for ; Thu, 11 Dec 2025 09:25:57 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 342cd by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 11 Dec 2025 09:25:57 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Kristof Provost Subject: git: a717a40f8449 - stable/14 - pf: relax sctp v_tag verification List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kp X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: a717a40f84490473a3bad5fa012ddac13e9dca60 Auto-Submitted: auto-generated Date: Thu, 11 Dec 2025 09:25:57 +0000 Message-Id: <693a8e25.342cd.30d66731@gitrepo.freebsd.org> The branch stable/14 has been updated by kp: URL: https://cgit.FreeBSD.org/src/commit/?id=a717a40f84490473a3bad5fa012ddac13e9dca60 commit a717a40f84490473a3bad5fa012ddac13e9dca60 Author: Kristof Provost AuthorDate: 2025-11-25 09:59:02 +0000 Commit: Kristof Provost CommitDate: 2025-12-11 09:22:33 +0000 pf: relax sctp v_tag verification pf was too strict when validating SCTP tags. When a server receives a retransmitted INIT it will reply with a random initiate tag every time. However, pf saves the first initiate tag and expects every subsequent INIT_ACK retransmission to have the same tag. This is not the case, leading to endless INIT/INIT_ACK cycles. Allow the tag to be updated as long as we've not gone past COOKIE_WAIT. Add a test case to verify this. MFC after: 2 weeks See also: https://redmine.pfsense.org/issues/16516 Sponsored by: Rubicon Communications, LLC ("Netgate") (cherry picked from commit bc3b72ff48953551e0e8bd6e5a2c718ecd973285) --- sys/netpfil/pf/pf.c | 8 ++++-- tests/sys/netpfil/pf/sctp.py | 67 ++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 73 insertions(+), 2 deletions(-) diff --git a/sys/netpfil/pf/pf.c b/sys/netpfil/pf/pf.c index 44d72d228104..dbd5ef04ef00 100644 --- a/sys/netpfil/pf/pf.c +++ b/sys/netpfil/pf/pf.c @@ -6238,9 +6238,13 @@ pf_test_state_sctp(struct pf_kstate **state, struct pfi_kkif *kif, } if (src->scrub != NULL) { - if (src->scrub->pfss_v_tag == 0) { + /* + * Allow tags to be updated, in case of retransmission of + * INIT/INIT_ACK chunks. + **/ + if (src->state <= SCTP_COOKIE_WAIT) src->scrub->pfss_v_tag = pd->hdr.sctp.v_tag; - } else if (src->scrub->pfss_v_tag != pd->hdr.sctp.v_tag) + else if (src->scrub->pfss_v_tag != pd->hdr.sctp.v_tag) return (PF_DROP); } diff --git a/tests/sys/netpfil/pf/sctp.py b/tests/sys/netpfil/pf/sctp.py index da42ce527195..a871994ee118 100644 --- a/tests/sys/netpfil/pf/sctp.py +++ b/tests/sys/netpfil/pf/sctp.py @@ -530,6 +530,73 @@ class TestSCTP(VnetTestTemplate): assert re.search(r"epair.*sctp 192.0.2.1:.*192.0.2.3:1234", states) assert re.search(r"epair.*sctp 192.0.2.1:.*192.0.2.2:1234", states) +class TestSCTP_SRV(VnetTestTemplate): + REQUIRED_MODULES = ["sctp", "pf"] + TOPOLOGY = { + "vnet1": {"ifaces": ["if1"]}, + "vnet2": {"ifaces": ["if1"]}, + "if1": {"prefixes4": [("192.0.2.1/24", "192.0.2.2/24")]}, + } + + def vnet2_handler(self, vnet): + ToolsHelper.print_output("/sbin/pfctl -e") + ToolsHelper.pf_rules([ + "set state-policy if-bound", + "pass inet proto sctp", + "pass on lo"]) + + # Start an SCTP server process, pipe the ppid + data back to the other vnet? + srv = SCTPServer(socket.AF_INET, port=1234) + while True: + srv.accept(vnet) + + @pytest.mark.require_user("root") + @pytest.mark.require_progs(["scapy"]) + def test_initiate_tag_check(self): + # Ensure we don't send ABORTs in response to the other end's INIT_ACK + # That'd interfere with our test. + ToolsHelper.print_output("/sbin/sysctl net.inet.sctp.blackhole=2") + + import scapy.all as sp + + packet = sp.IP(src="192.0.2.1", dst="192.0.2.2") \ + / sp.SCTP(sport=1234, dport=1234) \ + / sp.SCTPChunkInit(init_tag=1, n_in_streams=1, n_out_streams=1, a_rwnd=1500) + packet.show() + + r = sp.sr1(packet, timeout=3) + assert r + r.show() + assert r.getlayer(sp.SCTP) + assert r.getlayer(sp.SCTPChunkInitAck) + assert r.getlayer(sp.SCTP).tag == 1 + + # Send another INIT with the same initiate tag, expect another init ack + packet = sp.IP(src="192.0.2.1", dst="192.0.2.2") \ + / sp.SCTP(sport=1234, dport=1234) \ + / sp.SCTPChunkInit(init_tag=1, n_in_streams=1, n_out_streams=1, a_rwnd=1500) + packet.show() + + r = sp.sr1(packet, timeout=3) + assert r + r.show() + assert r.getlayer(sp.SCTP) + assert r.getlayer(sp.SCTPChunkInitAck) + assert r.getlayer(sp.SCTP).tag == 1 + + # Send an INIT with a different initiate tag, expect another init ack + packet = sp.IP(src="192.0.2.1", dst="192.0.2.2") \ + / sp.SCTP(sport=1234, dport=1234) \ + / sp.SCTPChunkInit(init_tag=42, n_in_streams=1, n_out_streams=1, a_rwnd=1500) + packet.show() + + r = sp.sr1(packet, timeout=3) + assert r + r.show() + assert r.getlayer(sp.SCTP) + assert r.getlayer(sp.SCTPChunkInitAck) + assert r.getlayer(sp.SCTP).tag == 42 + class TestSCTPv6(VnetTestTemplate): REQUIRED_MODULES = ["sctp", "pf"] TOPOLOGY = {