From nobody Wed Oct 1 19:01:57 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4ccPS51FXbz69BVR for ; Wed, 01 Oct 2025 19:02:13 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: from mail-ed1-x532.google.com (mail-ed1-x532.google.com [IPv6:2a00:1450:4864:20::532]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4ccPS461Ljz3r41 for ; Wed, 01 Oct 2025 19:02:12 +0000 (UTC) (envelope-from mjguzik@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-ed1-x532.google.com with SMTP id 4fb4d7f45d1cf-631787faf35so445219a12.3 for ; Wed, 01 Oct 2025 12:02:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1759345330; x=1759950130; darn=freebsd.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=tZlFF6UX6UdWtMYNYKUCsaA/yqPx4KuP6FOYM9p3mFI=; b=MXpyDezUouUkJBeN/i+xCJjju5pHCA5ZJySHTp0w0dACMEErQxHKPSJkxQExawxPG0 mpBFl7fYJnVUezZp273OVFfaLIWGhg/YGL7jdrhHPwr0g7XbKOOGkGGTw48C8vhFMM6a odkAw484pzOzKGl9YAU4bDKwPH1QZFCTlyDHnMXWqKbexbND5yzpIaqkxw/WF2vBk270 IiC8XmCPIc8rZkzPcZsQr90ACIKeWxn4gyLybyTtW+VyxYK5+mqb0kgsBqmyjmaKw4PN 3JnCQXl12dvykfbavIS0YTEsDRymzA17ymh/K8PVw0nA30B4qjczR/wooUrU3zq2NE34 xQGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759345330; x=1759950130; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tZlFF6UX6UdWtMYNYKUCsaA/yqPx4KuP6FOYM9p3mFI=; b=pGMo2zOmqkL1fOi4o2QUoKEIEWsFTzIcXyVlpC25RWVxnP5tJEMdvZytzf/kJyjmhm oQ+RuIKDISgFUOIEeUGMps/flkHz4Qo9Udd0lUagx8HO/uR2R88It5h4dRVUiBTac53d aEhwSI7cpIi5M/Ig/BebizW+KQKje4WzcoFtdpGqKBZstT48NpxCu8y9TaTjCsIYoRR9 wdbmqv/PYjtRHqJv3TmsrrXbm2e6e9ERZRAkDJPtjLZlIvpgd+Sb5agjezy6ozgdlqzL sCLRHXw1ouN2n+KQbDHA0Zmof3tRNs5TOJ7nI+PM9Ix57WGpgPmzpfk2sehcr5t0vXi/ sN2A== X-Forwarded-Encrypted: i=1; AJvYcCUJzEo8Gv4qQ5nDxJERHEWUPQdkHpn6K9IvnF2zJNBuU/hQ1B+rv4Num45vz1clBpA0dO6Mj8kNOj2yxAMkHbNFr0Sq2w==@freebsd.org X-Gm-Message-State: AOJu0Yz0UndQKPrw5443/S8xKkGre33mIGcbBEWgKUuJMXn9Lqb3EKPm K6L/GVxBu6jXKW0Qwg4fcs8XxQ0JgRYpk5t7wqOtk+pIwLvIG+mpdkikOqflD1vL5P+SQa1TXCh Mv9mKcyaXNg4YWFyJhStLTG9ackYUWHw= X-Gm-Gg: ASbGnctn73S58H2LUj/beq2X9gVW4tSFSPRKjKltL4P7ZgtoJ1fZacUpmbxjUUs1I3Y +HlxfeR2V2Ss9VGN2uxIvlvLBUZBmDE/9NBB0x8rsZbFpuyrFhqE/ZuguHiqP2aZ4S5zRy9TKMq zpqWCzIavizvYIFlNTgVTWOTIJDyxyT0hVMRTnzfTsEUXv6dZQYKL45A5FPqz4C4uI3xnCaylog eRRBQBccMCwBGd52yibwSamEsahgowuD8nhwUURciIA8eaVYcZ1oSZYB0dmbzm6MkO6hq/BY7Qn X-Google-Smtp-Source: AGHT+IHr2apRMhHVsNK+1A9plCmVrsB6gIBUnC+49lg4IWJLgImm5lnpyFwLAcm3FWW3FOR2jAFqBlUbjk6h8YiN1V8= X-Received: by 2002:a17:907:608b:b0:b45:1063:fb52 with SMTP id a640c23a62f3a-b46e479ffb8mr624627466b.39.1759345329614; Wed, 01 Oct 2025 12:02:09 -0700 (PDT) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 References: <202509270401.58R41A7b014829__21824.1523530864$1758945716$gmane$org@gitrepo.freebsd.org> <85c486e1-6fde-4f4a-b4ce-bfbec7bb693f@FreeBSD.org> In-Reply-To: <85c486e1-6fde-4f4a-b4ce-bfbec7bb693f@FreeBSD.org> From: Mateusz Guzik Date: Wed, 1 Oct 2025 21:01:57 +0200 X-Gm-Features: AS18NWBPGSrdcWCLk_MRHUAlUAubzIc5ihH8S99NsaQmjcsE7MHib4svioVWjzo Message-ID: Subject: Re: git: 08f06aa1b4fb - main - vfs: retire the VCALL macro To: Renato Botelho Cc: Mateusz Guzik , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Queue-Id: 4ccPS461Ljz3r41 On Wed, Oct 1, 2025 at 8:35=E2=80=AFPM Renato Botelho w= rote: > > On 27/09/25 01:01, Mateusz Guzik wrote: > > The branch main has been updated by mjg: > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=3D08f06aa1b4fb6db0d8beb3e1= c328b1c1adbec13a > > > > commit 08f06aa1b4fb6db0d8beb3e1c328b1c1adbec13a > > Author: Mateusz Guzik > > AuthorDate: 2025-09-27 02:01:32 +0000 > > Commit: Mateusz Guzik > > CommitDate: 2025-09-27 04:00:59 +0000 > > > > vfs: retire the VCALL macro > > > > There is precisely one place using it and even that should probabl= y go > > away. > > --- > > sys/fs/nullfs/null_vnops.c | 2 +- > > sys/sys/vnode.h | 5 ----- > > 2 files changed, 1 insertion(+), 6 deletions(-) > > > > diff --git a/sys/fs/nullfs/null_vnops.c b/sys/fs/nullfs/null_vnops.c > > index 74c1a8f3acb6..ba29b0485326 100644 > > --- a/sys/fs/nullfs/null_vnops.c > > +++ b/sys/fs/nullfs/null_vnops.c > > @@ -306,7 +306,7 @@ null_bypass(struct vop_generic_args *ap) > > * with the modified argument structure. > > */ > > if (vps_p[0] !=3D NULL && *vps_p[0] !=3D NULL) { > > - error =3D VCALL(ap); > > + error =3D ap->a_desc->vdesc_call(ap); > > } else { > > printf("null_bypass: no map for %s\n", descp->vdesc_name)= ; > > error =3D EINVAL; > > diff --git a/sys/sys/vnode.h b/sys/sys/vnode.h > > index 6ef9bbec9446..fcfb8716fc52 100644 > > --- a/sys/sys/vnode.h > > +++ b/sys/sys/vnode.h > > @@ -594,11 +594,6 @@ void assert_vop_unlocked(struct vnode *vp, con= st char *str); > > > > #endif /* INVARIANTS */ > > > > -/* > > - * This call works for vnodes in the kernel. > > - */ > > -#define VCALL(c) ((c)->a_desc->vdesc_call(c)) > > - > > #define DOINGASYNC(vp) \ > > (((vp)->v_mount->mnt_kern_flag & MNTK_ASYNC) !=3D 0 && \ > > ((curthread->td_pflags & TDP_SYNCIO) =3D=3D 0)) > > > > > > FYI, this commit along with retirement of NULLVP and VREF broke > open-vm-kmod build on current. I wonder if there are move ports that > could be affected. > I could bump __freebsd_version for it, but what you can do is simply not use the old stuff on any supported branch.