From owner-p4-projects@FreeBSD.ORG  Mon Mar 20 15:50:30 2006
Return-Path: <owner-p4-projects@FreeBSD.ORG>
X-Original-To: p4-projects@freebsd.org
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id E1E3216A537; Mon, 20 Mar 2006 15:50:29 +0000 (UTC)
X-Original-To: perforce@freebsd.org
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id EE11016A4E0;
	Mon, 20 Mar 2006 15:50:28 +0000 (UTC)
	(envelope-from Todd.Miller@sparta.com)
Received: from M4.sparta.com (M4.sparta.com [157.185.61.2])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 8C7D443D66;
	Mon, 20 Mar 2006 15:50:16 +0000 (GMT)
	(envelope-from Todd.Miller@sparta.com)
Received: from Beta5.sparta.com (beta5.sparta.com [157.185.63.21])
	by M4.sparta.com (8.13.5/8.13.5) with ESMTP id k2KFoFkP021340;
	Mon, 20 Mar 2006 09:50:15 -0600
Received: from nemo.columbia.ads.sparta.com (nemo.columbia.sparta.com
	[157.185.80.75])
	by Beta5.sparta.com (8.12.11/8.13.1) with ESMTP id k2KFoFhH026350;
	Mon, 20 Mar 2006 09:50:16 -0600
Received: from [127.0.0.1] ([157.185.80.253]) by nemo.columbia.ads.sparta.com
	with Microsoft SMTPSVC(6.0.3790.1830); 
	Mon, 20 Mar 2006 10:50:15 -0500
In-Reply-To: <200603201525.k2KFPkaO012910@repoman.freebsd.org>
References: <200603201525.k2KFPkaO012910@repoman.freebsd.org>
Mime-Version: 1.0 (Apple Message framework v746.3)
Content-Type: text/plain; charset=US-ASCII; format=flowed
Message-Id: <CB5AEECF-F062-4C11-832A-0BBCC8A23C6A@sparta.com>
Content-Transfer-Encoding: 7bit
From: Todd Miller <Todd.Miller@sparta.com>
Date: Mon, 20 Mar 2006 10:50:13 -0500
To: Todd Miller <millert@freebsd.org>
X-Mailer: Apple Mail (2.746.3)
X-OriginalArrivalTime: 20 Mar 2006 15:50:15.0276 (UTC)
	FILETIME=[FAE272C0:01C64C35]
Cc: Perforce Change Reviews <perforce@freebsd.org>
Subject: Re: PERFORCE change 93627 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 20 Mar 2006 15:50:30 -0000


On Mar 20, 2006, at 3:25 PM, Todd Miller wrote:

> http://perforce.freebsd.org/chv.cgi?CH=93627
>
> Change 93627 by millert@millert_p3 on 2006/03/20 15:25:46
>
> 	In fdcopy() set newfdp->fd_freefile after the first loop
> 	over fdp instead of the loop over newfdp.  This means we
> 	never enter fdused() with fd_freefile == -1.  It also fixes
> 	a bug when fdp->fd_lastfile == -1.  Previously, if
> 	fdp->fd_lastfile was -1 newfdp->fd_freefile would get set
> 	to 1 instead of 0 since newfdp->fd_lastfile is initialized
> 	to 0 and newfdp->fd_freefile will not have been set in the
> 	first loop (which doesn't run at all in this case).
> 	It's not clear why newfdp->fd_freefile is -1 at this point.

That last line should have read:
     It's not clear why newfdp->fd_lastfile is -1 at this point.

  - todd