Date: Mon, 20 Mar 2006 10:50:13 -0500 From: Todd Miller <Todd.Miller@sparta.com> To: Todd Miller <millert@freebsd.org> Cc: Perforce Change Reviews <perforce@freebsd.org> Subject: Re: PERFORCE change 93627 for review Message-ID: <CB5AEECF-F062-4C11-832A-0BBCC8A23C6A@sparta.com> In-Reply-To: <200603201525.k2KFPkaO012910@repoman.freebsd.org> References: <200603201525.k2KFPkaO012910@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mar 20, 2006, at 3:25 PM, Todd Miller wrote: > http://perforce.freebsd.org/chv.cgi?CH=93627 > > Change 93627 by millert@millert_p3 on 2006/03/20 15:25:46 > > In fdcopy() set newfdp->fd_freefile after the first loop > over fdp instead of the loop over newfdp. This means we > never enter fdused() with fd_freefile == -1. It also fixes > a bug when fdp->fd_lastfile == -1. Previously, if > fdp->fd_lastfile was -1 newfdp->fd_freefile would get set > to 1 instead of 0 since newfdp->fd_lastfile is initialized > to 0 and newfdp->fd_freefile will not have been set in the > first loop (which doesn't run at all in this case). > It's not clear why newfdp->fd_freefile is -1 at this point. That last line should have read: It's not clear why newfdp->fd_lastfile is -1 at this point. - todd
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CB5AEECF-F062-4C11-832A-0BBCC8A23C6A>