From owner-freebsd-ports-bugs@FreeBSD.ORG Sat Dec 5 11:00:03 2009 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 835CA1065670 for ; Sat, 5 Dec 2009 11:00:03 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 435B68FC12 for ; Sat, 5 Dec 2009 11:00:03 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id nB5B03LQ093363 for ; Sat, 5 Dec 2009 11:00:03 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id nB5B03vf093362; Sat, 5 Dec 2009 11:00:03 GMT (envelope-from gnats) Resent-Date: Sat, 5 Dec 2009 11:00:03 GMT Resent-Message-Id: <200912051100.nB5B03vf093362@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Anselm Strauss Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 98ECB106566B for ; Sat, 5 Dec 2009 10:57:15 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21]) by mx1.freebsd.org (Postfix) with ESMTP id 87FD58FC13 for ; Sat, 5 Dec 2009 10:57:15 +0000 (UTC) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.14.3/8.14.3) with ESMTP id nB5AvFRM091423 for ; Sat, 5 Dec 2009 10:57:15 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.14.3/8.14.3/Submit) id nB5AvFkN091422; Sat, 5 Dec 2009 10:57:15 GMT (envelope-from nobody) Message-Id: <200912051057.nB5AvFkN091422@www.freebsd.org> Date: Sat, 5 Dec 2009 10:57:15 GMT From: Anselm Strauss To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: ports/141187: freebsd-snapshot does not check /etc/rc.conf.d X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 05 Dec 2009 11:00:03 -0000 >Number: 141187 >Category: ports >Synopsis: freebsd-snapshot does not check /etc/rc.conf.d >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sat Dec 05 11:00:02 UTC 2009 >Closed-Date: >Last-Modified: >Originator: Anselm Strauss >Release: 8.0 >Organization: - >Environment: FreeBSD hulk.l.ttyv0.net 8.0-RELEASE FreeBSD 8.0-RELEASE #1: Fri Dec 4 00:20:25 CET 2009 root@hulk.l.ttyv0.net:/usr/obj/usr/src/sys/CUSTOM amd64 >Description: Port: freebsd-snapshot The snapshot command checks whether zfs is enabled on a system. It does so by looking only at /etc/rc.conf. If zfs is configured in /etc/rc.conf.d/zfs, the snapshot command does not know about it, and behaves as zfs was disabled. Consequently snapshots of zfs filesystems can not be managed with the command, although zfs is enabled and running. >How-To-Repeat: Assuming you have zfs_enable="YES" in /etc/rc.conf and "snapshot list" shows zfs snapshots: move the zfs_enable setting to /etc/rc.conf.d/zfs and run "snapshot list" again. No zfs snapshots will show up any more. >Fix: The snapshot command should also source zfs config with "load_rc_config zfs". Patch attached with submission follows: *** snapshot.orig Fri Dec 4 19:24:06 2009 --- snapshot Sat Dec 5 10:54:53 2009 *************** *** 81,86 **** --- 81,87 ---- source_rc_confs; \ fi; \ . /etc/rc.subr; \ + load_rc_config zfs; \ if checkyesno zfs_enable; then \ echo 'yes'; \ else \ >Release-Note: >Audit-Trail: >Unformatted: