From owner-freebsd-current@FreeBSD.ORG  Sun Jul 25 17:39:37 2004
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 687A716A4CE; Sun, 25 Jul 2004 17:39:37 +0000 (GMT)
Received: from sccrmhc13.comcast.net (sccrmhc13.comcast.net [204.127.202.64])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id F3FD343D39; Sun, 25 Jul 2004 17:39:36 +0000 (GMT)
	(envelope-from rodrigc@crodrigues.org)
Received: from h00609772adf0.ne.client2.attbi.com ([66.30.114.143])
          by comcast.net (sccrmhc13) with ESMTP
          id <2004072517393601600ojtv1e>; Sun, 25 Jul 2004 17:39:36 +0000
Received: from h00609772adf0.ne.client2.attbi.com (localhost [127.0.0.1])
	i6PHdZRj001313;	Sun, 25 Jul 2004 13:39:35 -0400 (EDT)
	(envelope-from rodrigc@h00609772adf0.ne.client2.attbi.com)
Received: (from rodrigc@localhost)i6PHdYLV001312;
	Sun, 25 Jul 2004 13:39:34 -0400 (EDT)	(envelope-from rodrigc)
Date: Sun, 25 Jul 2004 13:39:34 -0400
From: Craig Rodrigues <rodrigc@crodrigues.org>
To: Mike Makonnen <mtm@identd.net>
Message-ID: <20040725173934.GA1213@crodrigues.org>
References: <20040725141208.GA28326@rogue.acs-et.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20040725141208.GA28326@rogue.acs-et.com>
User-Agent: Mutt/1.4.1i
cc: freebsd-current@freebsd.org
cc: freebsd-ports@freebsd.org
Subject: Re: HEADS UP: change in ports rc.d script behaviour
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 25 Jul 2004 17:39:37 -0000

On Sun, Jul 25, 2004 at 05:12:08PM +0300, Mike Makonnen wrote:
> 4. If you must include a default value for an rc.conf(5) knob,
>    make sure that you put it in an if [ -z "$foo_knob"] clause.

As a simple alternative to an if clause, I've done this for the 
isc-dhcp3-server port:

[ -z "$dhcpd_enable" ] && dhcpd_enable="NO"


I submitted this PR with the full patch:
http://www.freebsd.org/cgi/query-pr.cgi?pr=69590


-- 
Craig Rodrigues        
http://crodrigues.org
rodrigc@crodrigues.org