From owner-freebsd-current@freebsd.org Mon Dec 11 23:33:28 2017 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D1B08EA2904 for ; Mon, 11 Dec 2017 23:33:28 +0000 (UTC) (envelope-from asomers@gmail.com) Received: from mail-lf0-x233.google.com (mail-lf0-x233.google.com [IPv6:2a00:1450:4010:c07::233]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 3E26C7F443 for ; Mon, 11 Dec 2017 23:33:28 +0000 (UTC) (envelope-from asomers@gmail.com) Received: by mail-lf0-x233.google.com with SMTP id x204so21112715lfa.11 for ; Mon, 11 Dec 2017 15:33:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=/pKKM24/nRkI96zpuV4QHAG+yerDvb3NzsfvVcaw7R4=; b=st2XiVJ8PA6ouwKxLYIrqsug4O/kP26mQxdLcooFcPlVsouJ95fWjKRImaHuXodg37 gqjKLVuuT97RKW+i44eM8B3lrdUnpyhiBso2RuchCDMv8xbXdTUlx5eepeMmQ8KhdJOO T8FlT+vMXgdsf3Uyr/Yr3j3T9Ltyjph7vQ+kuvQKHTwfe6+LvBhLD70jyLOSVPl0m4tz vZOS0jMIpeEbmx5Wp9nVbmePqImrioXp3S2JsdOoiPa0qhS/KBNzUsbUI3ms8erkjQ8p 22QXkD1ugY3nobj/mfUTuq5WEDK4W5uP1rALMjdJ98rgdWBrQRLruqk6he+wotdLMKPx HfZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=/pKKM24/nRkI96zpuV4QHAG+yerDvb3NzsfvVcaw7R4=; b=P6i8NbpgyMyscmadZSxskVD5hwMCpTH9kbD4ds9VhQ7ITaBWnk8eQeKZDaTxxLTETe 00H1eq/yQvbVK0wSqdpCi+bSFgNWpNuPdUJM1qXJtaNT4dHZlbyWz7A5FtRwWxANv0xJ 1YzKOHwmnvAlv0Nvb2tvVlym72wszcmjncQi5dDUqcjr1Vb5KNTHM7qOSYm4lQRiGSF5 jgyyguWhpkC9kibNqyYOV1DHl3UMshyPBp6y1QTMztzXv1/HfN5in6673qYmYn+91FJY zpA/5mPO5PLmY826biOnY8mcbg8Xe8Nh4d8Zn5Pt/8Dv20am25974BD4aZhbhXTsJ9ts 7cPA== X-Gm-Message-State: AKGB3mIecZbqlGE3BtBPC3n5eqoC67PQqZKxh9qkTCHPnsqVt4Ie3oEi Yr3hEqKgtlnWDlRYGhY8n3mSidpJtM+lP9J28JU= X-Google-Smtp-Source: ACJfBotceu2tO+aTsOMUUr+/sQxUPsAT4+XSrLuME8YvikluLdAFPAz5OpGsRKJ2+AG1aVtAyaNt7ft3eRv/f4osy+M= X-Received: by 10.25.198.147 with SMTP id w141mr790138lff.84.1513035205028; Mon, 11 Dec 2017 15:33:25 -0800 (PST) MIME-Version: 1.0 Sender: asomers@gmail.com Received: by 10.179.76.19 with HTTP; Mon, 11 Dec 2017 15:33:24 -0800 (PST) In-Reply-To: References: From: Alan Somers Date: Mon, 11 Dec 2017 16:33:24 -0700 X-Google-Sender-Auth: a3RoW0UcZu8-rvxeTkMHyPZIWRo Message-ID: Subject: Re: don't know how to load module '/boot/loader' To: Warner Losh Cc: FreeBSD CURRENT Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Dec 2017 23:33:28 -0000 Yep, I can confirm that r326772 introduced the bug, and it is fixed by r326784. Thanks for the quick turnaround. -Alan On Mon, Dec 11, 2017 at 4:16 PM, Warner Losh wrote: > Ooops I lied. r326784 should fix it. Now I have flight attendants yelling > at me to put this computer away.... > > Warner > > On Mon, Dec 11, 2017 at 4:06 PM, Warner Losh wrote: > >> I'm seeing the same bug in my qemu VM setup. I'm about to land, so won't >> likely be able to fix this until I get to the hotel, but I'm pretty sure >> that I know what caused it. I didn't notice it before the commit (I gotta >> get a better regression suite in place for this stuff, rather than the >> ad-hoc testing I've been able to do). >> >> Warner >> >> On Mon, Dec 11, 2017 at 3:37 PM, Alan Somers wrote: >> >>> On Mon, Dec 11, 2017 at 3:30 PM, Warner Losh wrote: >>> >>>> >>>> >>>> On Mon, Dec 11, 2017 at 3:26 PM, Alan Somers >>>> wrote: >>>> >>>>> On Mon, Dec 11, 2017 at 3:19 PM, Warner Losh wrote: >>>>> >>>>>> >>>>>> >>>>>> On Mon, Dec 11, 2017 at 3:03 PM, Alan Somers >>>>>> wrote: >>>>>> >>>>>>> I just upgraded my head machine to r326772. Now, boot2 can't find >>>>>>> the >>>>>>> loader. Instead, it tries to boot the kernel directly, which fails >>>>>>> because >>>>>>> the ZFS module isn't loaded. If I break into boot2 and type "boot >>>>>>> /boot/loader" I get the error "don't know how to load module >>>>>>> '/boot/loader'". I last updated on 30-Nov, so this bug must've been >>>>>>> introduced since then. Any ideas? >>>>>>> >>>>>>> BTW, I can successfully boot with the following commands: >>>>>>> unload >>>>>>> load /boot/kernel/kernel >>>>>>> load zfs >>>>>>> boot >>>>>>> >>>>>>> http://bayimg.com/iAKmFaAgl >>>>>> >>>>>> >>>>>> I'd bisect :) >>>>>> >>>>>> However, try to update to just before this commit: >>>>>> >>>>>> Author: imp >>>>>> Date: Fri Dec 8 19:57:16 2017 +0000 >>>>>> >>>>>> Create interp class. >>>>>> >>>>>> Create an interp class. Use it to separate out the different >>>>>> types of >>>>>> interpreters: forth and simple with function pointers rather than >>>>>> via #ifdefs. >>>>>> >>>>>> Obtained from: lua boot loader project >>>>>> (via https://bsdimp@github.com/bsdimp/freebsd.git >>>>>> lua-bootloader) >>>>>> Sponsored by: Netflix >>>>>> >>>>>> >>>>>> git-svn-id: svn+ssh://svn.freebsd.org/base/head@326712 >>>>>> ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f >>>>>> >>>>>> would be a good place to start. >>>>>> >>>>>> It's a shame we can't create zpool images with an unpriv'd user >>>>>> command. Would help out the ZFS testing of the boot loader refinement. >>>>>> >>>>>> Warner >>>>>> >>>>> >>>>> If I bisect this, what parts do I need to reinstall each time? A full >>>>> buildworld would be too slow. Is it sufficient to reinstall stand? >>>>> >>>> >>>> Just rebuild stand, reinstall it and reboot. >>>> >>>> Also, why are you trying to load /boot/loader from /boot/zfsloader? >>>> That has me confused. The screen shot looks like it found the kernel OK and >>>> was going to boot it, but then you interrupted it, unloaded it and tried to >>>> load /boot/loader. Shouldn't that be /boot/kernel or /boot/kernel.old or >>>> something like that? >>>> >>>> OK is /boot/loader's prompt (boot2 has no such prompt).... maybe the >>>> real bug here is that the menu has stopped working leading to your >>>> confusion... >>>> >>> >>>> Warner >>>> >>> >>> It certainly could be a bug in the menu. I'm definitely confused, >>> because this is a domain I've seldom dealt with, since it usually just >>> works. If I'm actually in /boot/loader, then there are two problems: >>> 1) The menu isn't working >>> 2) The loader isn't reading /boot/loader.conf. >>> >> >> >