From owner-svn-src-all@freebsd.org Tue Jan 10 22:00:50 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9068BCAA230; Tue, 10 Jan 2017 22:00:50 +0000 (UTC) (envelope-from jkim@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) by mx1.freebsd.org (Postfix) with ESMTP id 003441301; Tue, 10 Jan 2017 22:00:49 +0000 (UTC) (envelope-from jkim@FreeBSD.org) Subject: Re: svn commit: r311667 - in head/sys/contrib/dev/acpica: components/namespace components/tables include To: John Baldwin , "Conrad E. Meyer" References: <201701080626.v086QXDx022252@repo.freebsd.org> <7685799.RHuinLcsJW@ralph.baldwin.cx> <53d948ef-9e7e-422f-aead-39437abc8352@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org From: Jung-uk Kim Message-ID: <0e8abb94-160a-7ca2-1c67-3d3ef8fa522e@FreeBSD.org> Date: Tue, 10 Jan 2017 17:00:49 -0500 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <53d948ef-9e7e-422f-aead-39437abc8352@FreeBSD.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Jan 2017 22:00:50 -0000 On 01/09/2017 13:01, Jung-uk Kim wrote: > On 01/09/2017 12:08, John Baldwin wrote: >> On Sunday, January 08, 2017 06:26:33 AM Conrad E. Meyer wrote: >>> Author: cem >>> Date: Sun Jan 8 06:26:33 2017 >>> New Revision: 311667 >>> URL: https://svnweb.freebsd.org/changeset/base/311667 >>> >>> Log: >>> Add some additional ACPI methods for DRM >>> >>> Add AcpiGetDataFull and AcpiGetTableWithSize. >>> >>> Submitted by: Matt Macy >> >> Have these been submitted upstream? The Intel folks are generally quite >> responsive on freebsd-acpi@FreeBSD.org and this codebase is actively >> maintained externally. > > Please submit upstream first. > > https://github.com/acpica/acpica Since nobody responded, I just googled about it. It seems these two functions, AcpiGetDataFull() (aka. acpi_get_data_full() in Linux) and AcpiGetTableWithSize() (aka. acpi_get_table_with_size() in Linux), were only added in linux-pm tree and we only need them for "Graphics" repository. - AcpiGetDataFull() This function is only called by acpi_get_device_data(), which is, in turn, only called by acpi_bus_get_device() with *NULL* callback. Therefore, I don't see any reason to pollute contrib code for this. - AcpiGetTableWithSize() This API is now deprecated by the upstream: http://marc.info/?l=linux-acpi&m=148169906815835 http://marc.info/?l=linux-acpi&m=148169907615836 http://marc.info/?l=linux-acpi&m=148169908115837 http://marc.info/?l=linux-acpi&m=148169908615838 http://marc.info/?l=linux-acpi&m=148169909215840 The code changes were committed to both ACPICA: https://github.com/acpica/acpica/commit/cac67909 and committed to linux-pm tree: https://git.kernel.org/cgit/linux/kernel/git/rafael/linux-pm.git/commit?id=6b11d1d677132816252004426ef220ccd3c92d2f This means it will be removed from future Linux kernel. Therefore, we should NOT implement the deprecated API. Please back out r311667 and r311843 and let me know if you need any help in resolving this matter. Jung-uk Kim