From owner-freebsd-current@FreeBSD.ORG Fri May 29 19:54:21 2009 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3EEE7106566C for ; Fri, 29 May 2009 19:54:21 +0000 (UTC) (envelope-from ulf.lilleengen@gmail.com) Received: from mail-ew0-f164.google.com (mail-ew0-f164.google.com [209.85.219.164]) by mx1.freebsd.org (Postfix) with ESMTP id B05D78FC1A for ; Fri, 29 May 2009 19:54:20 +0000 (UTC) (envelope-from ulf.lilleengen@gmail.com) Received: by ewy8 with SMTP id 8so3035951ewy.43 for ; Fri, 29 May 2009 12:54:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:cc:subject:references:in-reply-to :x-enigmail-version:content-type:content-transfer-encoding; bh=AVKhpzZ4QxOEvizyIyraCCyoBUmVg1m8jYVTb5vo8hU=; b=RxJaiQl01kpd01dXvuKZpzpdy+dvXup04RJksi5ACICPBbSuluIiUHyULT/IK26o9y w2cBbamLdO9syUggNVNcIeR1AP2Gdq4d0EXcJ7j0t+J+ub5thYPoAJeXYfqHohizFt/y z/7Hw0Y5+XjrS+aEd+yr5ncGuNcxPPWQ7ofpE= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:x-enigmail-version:content-type :content-transfer-encoding; b=IFrUQ//ZTRHQdO1g6qi1LjlMZAZwMo5KIIuKPa0LklWvFWfyv6TMBiAA43eizp5RKD AbXgGjWUKquMy9IAk+jFXX4bCHkefth+LP4UAcSMecpFu+f1zSQ2FMV6e8PRjiTs50Ns yYQyxiLiqW1MYv1BSAq89G2prcs2tfT9iAp/Y= Received: by 10.210.17.2 with SMTP id 2mr2910443ebq.0.1243626859122; Fri, 29 May 2009 12:54:19 -0700 (PDT) Received: from carrot.geeknest.org (z032069.its-s.tudelft.nl [145.94.32.69]) by mx.google.com with ESMTPS id 28sm3123803eyg.14.2009.05.29.12.54.16 (version=TLSv1/SSLv3 cipher=RC4-MD5); Fri, 29 May 2009 12:54:16 -0700 (PDT) Message-ID: <4A202148.9090108@gmail.com> Date: Fri, 29 May 2009 19:54:16 +0200 From: Ulf Lilleengen User-Agent: Thunderbird 2.0.0.21 (X11/20090411) MIME-Version: 1.0 To: Andriy Gapon References: <4A1FEE04.1060202@freebsd.org> In-Reply-To: <4A1FEE04.1060202@freebsd.org> X-Enigmail-Version: 0.95.7 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: freebsd-current@freebsd.org Subject: Re: fixing kobj signatures X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 May 2009 19:54:21 -0000 Andriy Gapon wrote: > I think I have completed fixing signatures of kobj method implementations in the > whole head tree. > The current diff here: > http://people.freebsd.org/~avg/ > > It is quite arbitrarily split into the following files: > kobj-agp.diff > kobj-arm.diff > kobj-linker.diff > kobj-other.diff > kobj-sound.diff > > Most of the changes are quite trivial but not all. > > o kobj-linker.diff - I am not sure if changing interface signature was a good idea. > > o kobj-sound.diff - this is a slightly updated version of the patch previously > posted to multimedia ml; > Ariff, could you please let me know about your plans with respect to 8.0 release? > > o kobj-arm.diff - it seems that npe_miibus_writereg in > sys/arm/xscale/ixp425/if_npe.c) could now make use of non-void return type to > properly report errors (XXX cases). But I am not sure if it is actually checked in > the calling code (otherwise how does it work now?). > Maybe there are more places like that. > > Please review the patch. I might have done something wrong, made some obvious > mistake (like typo) or missed an opportunity to improve the code beyond mechanical > changes. > > I tested the patch by enabling 'notyet' definition of KOBJMETHOD in kobj.h and > building the following: all arm kernels (without modules), GENERIC kernels for all > archs that have them (with modules), LINT kernels for all archs that have them > (without modules). > > It is quite possible, of course, that some incorrect signatures were not found > using the above build. For instance, in the code under some non-default option. > But I think the number of such functions should be quite small and they should be > trivial to fix later. > > I propose this patch for inclusion into the three before 8.0 freeze depending on > response from Ariff. > if this patch is not committed before 8.0 freeze (whole or any significant portion > of the patch), then I'd like to request a branch under users/ where I could > integrate this patch for future merging. > >From http://people.freebsd.org/~avg/kobj-agp.diff: -static int -agp_nvidia_flush_tlb (device_t dev, int offset) +static void +agp_nvidia_flush_tlb (device_t dev) { struct agp_nvidia_softc *sc; u_int32_t wbc_reg, temp; @@ -379,7 +379,7 @@ agp_nvidia_flush_tlb (device_t dev, int offset) for(i = 0; i < pages; i++) temp = ag_virtual[i * PAGE_SIZE / sizeof(u_int32_t)]; - return (0); + return; } No need for the return;