From owner-freebsd-testing@FreeBSD.ORG Sun Mar 2 22:54:57 2014 Return-Path: Delivered-To: freebsd-testing@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 94FE99F3; Sun, 2 Mar 2014 22:54:57 +0000 (UTC) Received: from mail-pd0-x233.google.com (mail-pd0-x233.google.com [IPv6:2607:f8b0:400e:c02::233]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 5C9F912AF; Sun, 2 Mar 2014 22:54:57 +0000 (UTC) Received: by mail-pd0-f179.google.com with SMTP id w10so2923871pde.24 for ; Sun, 02 Mar 2014 14:54:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=content-type:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=XzADZYrhnA3Do9wgv++rt3aMnseh0DwcfqiGpOAYXSE=; b=RR0W4l5bUj7CgEfodEeikwAlmZiTDENKhOW+vgZSbsYz0ZfK1S8H+qILSAKY42tRZR Smef1CZ+sXaeZN99wANEOHvPQWFgyfBhZpT2X0tRM32LHHhdM12JTjHDIDCehcOH2Fp6 09SvDWpnVa+8+Dx29BufQyqGoeKQZrLsV7lECPz9yfcnrL60DubY/XQEQxpuwVgVuPYM hzFSEtcuR5eVApKJA6BHnFsgsU18v8MgYej5zItuFaVWWJFD1HIPl0hjE0kHCOL2MDYz ZGdh76sJdJhBFW/p9JeKHSkCSq+7f+OxshpaHvgOx7wAwgyfatVVa/uv9J4eF/sLkb3p k1eQ== X-Received: by 10.68.106.130 with SMTP id gu2mr15943381pbb.59.1393800897035; Sun, 02 Mar 2014 14:54:57 -0800 (PST) Received: from ?IPv6:2601:8:ab80:7d6:713a:b2d6:e030:b06f? ([2601:8:ab80:7d6:713a:b2d6:e030:b06f]) by mx.google.com with ESMTPSA id os1sm70682492pac.20.2014.03.02.14.54.54 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sun, 02 Mar 2014 14:54:55 -0800 (PST) Content-Type: text/plain; charset=windows-1252 Mime-Version: 1.0 (Mac OS X Mail 7.2 \(1874\)) Subject: Re: [PATCH] Integrate pjdfstest into the build From: Garrett Cooper In-Reply-To: Date: Sun, 2 Mar 2014 14:54:52 -0800 Content-Transfer-Encoding: quoted-printable Message-Id: <56D809A7-5387-475A-8C89-794E328F6935@gmail.com> References: <94D3F60A-1E12-418B-8313-E43C93878B95@gmail.com> To: Julio Merino X-Mailer: Apple Mail (2.1874) Cc: "freebsd-testing@freebsd.org" , Pawel Jakub Dawidek X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 02 Mar 2014 22:54:57 -0000 On Mar 2, 2014, at 1:31 PM, Julio Merino wrote: > On Mon, Jan 27, 2014 at 5:41 AM, Garrett Cooper = wrote: >> Hi all, >> The attached patch integrates pjdfstest into the build. It = also simplifies some logic in tests/sys/Makefile when copying Kyuafile. >=20 > Aaand one more time, apologies for the delay. I think I'm caught up = now! >=20 > * What's the point of PJDFSTEST_I_KNOW_WHAT_I_AM_DOING? *Why* is it a > very bad idea to do so? It=92s a safety belt. I=92ve run into cases where interrupted test runs fill up filesystems = with data (either free space or inodes). Depending on what method you = use to clean up the contents of directories, it can take ages to delete = all of the files (rm -rf for instance is a very linear operation, but = parallel rm -rf=92s are considerably quicker). I=92ll add a comment to = this effect. > * The 'tests' path component in pjdfstest/tests/ should go away; it is > redundant. It=92s not redundant; it=92s needed for the conf file: # make all =3D=3D=3D> pjdfstest (all) =3D=3D=3D> tests (all) make[1]: don't know how to make conf. Stop make[1]: stopped in /usr/src/tests/sys/pjdfstest/tests *** Error code 2 Stop. make: stopped in /usr/src/tests/sys/pjdfstest # git checkout -- tests/Makefile=20 =85 # echo $? 0 > * Add $FreeBSD$ tags everywhere where missing. I=92ll add those. > * The test files should move from tools/regression/pjdfstest/ into the > new location under tests/sys/ and be renamed to follow the conventions > under src/test (e.g. xx.t -> xx_test). Please talk to Pawel about this. These tests have been developed and are = maintained (to some degree) outside FreeBSD: = https://github.com/pjd/pjdfstest . I=92d rather treat this as an = integration of the 3rd party package, not a refactor. If you want me to = install the tests like _test though, I=92d be more than happy to do = that. Thank you :)! -Garrett=