From owner-svn-ports-all@freebsd.org Tue Dec 20 18:20:30 2016 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id DC10BC897C6 for ; Tue, 20 Dec 2016 18:20:30 +0000 (UTC) (envelope-from sunpoet@sunpoet.net) Received: from mail-oi0-x242.google.com (mail-oi0-x242.google.com [IPv6:2607:f8b0:4003:c06::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id A2B1C155F for ; Tue, 20 Dec 2016 18:20:30 +0000 (UTC) (envelope-from sunpoet@sunpoet.net) Received: by mail-oi0-x242.google.com with SMTP id m75so25116533oig.1 for ; Tue, 20 Dec 2016 10:20:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sunpoet-net.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=vRoDDe6vSZshqKOHyVgOexEv+4KwTZLP1HBJ0sE0Xf4=; b=NBTTn5Ha8NmK8GQrPv8NENzTN86UNPjl+NVt6Cd1M2sIYgweZkakGcR2FIh4w9M35H Lqit7+nwpgHXASXTo9aL+R+BPOMA6wDwlaaLgtVZ3qJYDEg8uwjn0R7uTHMAQ03LumnP MzHoOifCLq2Cv5otw+p2lTl/JZFhh3ZbPIqVtUzBU/Y9YWlHZPft++36vuPJgc+aU4HU GXcGF6e4G58lmwGOoBJyAyi5Ipds+PnpVCY25/A1PzkfMG/S7wHPQwFZIMrFCxHbt90a 6gKo0csJy3KX+WS8a9ge5/bbHl7/h1p24sMYFyroBU/N1ofLs+rn4VnkBfwfFN85rN/U RYaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=vRoDDe6vSZshqKOHyVgOexEv+4KwTZLP1HBJ0sE0Xf4=; b=We5QW5h57fOv9vJ9ytVINorFDotqSxJZBfR3800SW/8b2jBJ0hxKI3ceW31KiPE32S +iEtAlaVtoP4Bh26JIlfsSR3MeKnwqb/DabyJmwjiGonO69YnFlsHp5uhqtQL4xJ7lLQ CUjpeFhPO8ZgGtegSf7Up6EXyyDoeEutzXhvCAJVBzhFIOQjcs+d6rO3RHc6u0SIo3Hu igN/R1Apr9zVIcmkKP/ekKc5qlis2T19jd++gPyyqkzCFltGSKgGJwTxoHDJd3poU4BY gWG2jBO/IyMkd7LK/Bd5kJSSLqwoKFf/QD19fNDf7ICo8RMpqe0UnuGN/k2EIZmpf3z5 SntQ== X-Gm-Message-State: AIkVDXK1X1tXFrzcPMLwLq2hueWrCjZbTXNlvXX5VPT6jRoJgr8H6mGO0cwfadj5ekdaSjSHaOL2MDha7ZijUw== X-Received: by 10.157.52.145 with SMTP id g17mr330374otc.179.1482258030026; Tue, 20 Dec 2016 10:20:30 -0800 (PST) MIME-Version: 1.0 Sender: sunpoet@sunpoet.net Received: by 10.157.12.134 with HTTP; Tue, 20 Dec 2016 10:19:49 -0800 (PST) In-Reply-To: <05E4B71C-438F-41F5-B1C9-4E7DA0F314BB@adamw.org> References: <201612181520.uBIFKplk029455@repo.freebsd.org> <05E4B71C-438F-41F5-B1C9-4E7DA0F314BB@adamw.org> From: Sunpoet Po-Chuan Hsieh Date: Wed, 21 Dec 2016 02:19:49 +0800 X-Google-Sender-Auth: 2DectqAqubW2dcvJ0T7RdjAqlM0 Message-ID: Subject: Re: svn commit: r428858 - head/ftp/curl To: Adam Weinberger Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.23 X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Dec 2016 18:20:31 -0000 On Tue, Dec 20, 2016 at 12:53 AM, Adam Weinberger wrote: > > On 18 Dec, 2016, at 8:20, Sunpoet Po-Chuan Hsieh > wrote: > > > > Author: sunpoet > > Date: Sun Dec 18 15:20:50 2016 > > New Revision: 428858 > > URL: https://svnweb.freebsd.org/changeset/ports/428858 > > > > Log: > > - Change HTTP2 dependency from www/nghttp2 to www/libnghttp2 > > - Enable HTTP2 option by default > > - Bump PORTREVISION for dependency and package change > > > > Modified: > > head/ftp/curl/Makefile > > > > Modified: head/ftp/curl/Makefile > > ============================================================ > ================== > > --- head/ftp/curl/Makefile Sun Dec 18 15:20:42 2016 (r428857) > > +++ head/ftp/curl/Makefile Sun Dec 18 15:20:50 2016 (r428858) > > @@ -3,7 +3,7 @@ > > > > -HTTP2_BUILD_DEPENDS= nghttp2>=1.0.0:www/nghttp2 > > -HTTP2_CONFIGURE_WITH= nghttp2 > > -HTTP2_LIB_DEPENDS= libnghttp2.so:www/nghttp2 > > -HTTP2_RUN_DEPENDS= nghttp2>=1.0.0:www/nghttp2 > > +HTTP2_BUILD_DEPENDS= libnghttp2>=1.0.0:www/libnghttp2 > > +HTTP2_CONFIGURE_WITH= libnghttp2 > > +HTTP2_LIB_DEPENDS= libnghttp2.so:www/libnghttp2 > > +HTTP2_RUN_DEPENDS= libnghttp2>=1.0.0:www/libnghttp2 > > Hi Sunpoet, > > Having BUILD, RUN, and LIB depends on the same port looks odd; shouldn't > just LIB_DEPENDS be sufficient? www/mod_http2-devel does it too. > > Hello, Good catch! LIB_DEPENDS is required and {BUILD,RUN}_DEPENDS were added for version requirement. In fact, RUN_DEPENDS is not necessary. If required version was not installed, it will be blocked by BUILD_DEPENDS. Furthermore, BUILD_DEPENDS can also be removed here as libnghttp2 was born to be 1.0.0+. I'll update it later. Thanks! Regards, sunpoet # Adam > > > -- > Adam Weinberger > adamw@adamw.org > https://www.adamw.org > >