From owner-svn-src-all@freebsd.org  Sun Jul 31 13:43:16 2016
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id D4DF0BA9036;
 Sun, 31 Jul 2016 13:43:16 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2001:1900:2254:206c::16:87])
 by mx1.freebsd.org (Postfix) with ESMTP id CB19A184D;
 Sun, 31 Jul 2016 13:43:16 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1033)
 id C9A211E5C; Sun, 31 Jul 2016 13:43:16 +0000 (UTC)
Date: Sun, 31 Jul 2016 13:43:16 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Jilles Tjoelker <jilles@FreeBSD.org>
Cc: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: Re: svn commit: r303586 - head/bin/sh
Message-ID: <20160731134316.GB85936@FreeBSD.org>
References: <201607311311.u6VDBYr8066638@repo.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201607311311.u6VDBYr8066638@repo.freebsd.org>
User-Agent: Mutt/1.6.1 (2016-04-27)
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 31 Jul 2016 13:43:16 -0000

On Sun, Jul 31, 2016 at 01:11:34PM +0000, Jilles Tjoelker wrote:
> New Revision: 303586
> URL: https://svnweb.freebsd.org/changeset/base/303586
> 
> Log:
>   sh: Fix a clang warning.
>   
>   Submitted by:	bdrewery
> 
> Modified:
>   head/bin/sh/expand.c
> 
> Modified: head/bin/sh/expand.c
> ==============================================================================
> --- head/bin/sh/expand.c	Sun Jul 31 12:59:10 2016	(r303585)
> +++ head/bin/sh/expand.c	Sun Jul 31 13:11:34 2016	(r303586)
> @@ -473,7 +473,8 @@ expbackq(union node *cmd, int quoted, in
>  		if (--in.nleft < 0) {
>  			if (in.fd < 0)
>  				break;
> -			while ((i = read(in.fd, buf, sizeof buf)) < 0 && errno == EINTR);
> +			while ((i = read(in.fd, buf, sizeof buf)) < 0 && errno == EINTR)
> +				;

`continue;' would be even better; some tools might barf at stray semicolon.

./danfe