Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 16 Aug 2012 02:47:05 +0400
From:      Dmitry Marakasov <amdmi3@amdmi3.ru>
To:        Doug Barton <dougb@FreeBSD.org>
Cc:        svn-ports-head@freebsd.org, Alexey Dokuchaev <danfe@FreeBSD.org>, svn-ports-all@freebsd.org, ports-committers@freebsd.org
Subject:   Re: svn commit: r302552 - head/games/formido
Message-ID:  <20120815224705.GB4494@hades.panopticon>
In-Reply-To: <502C0684.3020806@FreeBSD.org>
References:  <201208150051.q7F0p1t4076309@svn.freebsd.org> <20120815093522.GA68308@FreeBSD.org> <20120815163216.GA99701@hades.panopticon> <502C0684.3020806@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
* Doug Barton (dougb@FreeBSD.org) wrote:

> > If we want to enforce style with a space, I think it
> > may be fixed in the whole tree by a sweeping commit, and I can
> > prepare this change after my 2 week vacation.
> 
> I did a WWW: related sweep a while back when I removed a bunch of stale
> Author: stuff, but I don't think I changed tab->space if the line was
> otherwise valid.
> 
> If someone is willing to put the work into sweeping this, not only would
> tab->space be useful, but what would also be useful would be to gather
> all the WWW URLs and test to see if they are still valid first. I'm sure
> a lot of them are not.

What are we going to do if they don't? We shouldn't remove them: first,
it may be a temporary error, second, even if an URL is dead completely
it may be used to find relevant info, e.g. in Internet Archive, or by
googling pages that link to that URL.

> The other issue for a sweep would be enforcing that WWW: be the last
> line in the file. This rule works for >90% of cases, although when I did
> the Author: sweep I noticed that there were a few valid exceptions.

Agreed.

-- 
Dmitry Marakasov   .   55B5 0596 FF1E 8D84 5F56  9510 D35A 80DD F9D2 F77D
amdmi3@amdmi3.ru  ..:  jabber: amdmi3@jabber.ru    http://www.amdmi3.ru



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120815224705.GB4494>