From owner-freebsd-bugs@FreeBSD.ORG  Thu Apr 23 11:12:41 2015
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id EDBB0C56
 for <freebsd-bugs@FreeBSD.org>; Thu, 23 Apr 2015 11:12:41 +0000 (UTC)
Received: from kenobi.freebsd.org (kenobi.freebsd.org
 [IPv6:2001:1900:2254:206a::16:76])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id BEE6A1DB7
 for <freebsd-bugs@FreeBSD.org>; Thu, 23 Apr 2015 11:12:41 +0000 (UTC)
Received: from bugs.freebsd.org ([127.0.1.118])
 by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id t3NBCfcE052563
 for <freebsd-bugs@FreeBSD.org>; Thu, 23 Apr 2015 11:12:41 GMT
 (envelope-from bugzilla-noreply@freebsd.org)
From: bugzilla-noreply@freebsd.org
To: freebsd-bugs@FreeBSD.org
Subject: [Bug 199641] Growfs does not compile in debugmode  (GFSDBG)
Date: Thu, 23 Apr 2015 11:12:41 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: Base System
X-Bugzilla-Component: bin
X-Bugzilla-Version: 10.1-STABLE
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: Affects Only Me
X-Bugzilla-Who: wjw@digiware.nl
X-Bugzilla-Status: New
X-Bugzilla-Priority: ---
X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform
 op_sys bug_status bug_severity priority component assigned_to reporter
Message-ID: <bug-199641-8@https.bugs.freebsd.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs/>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 23 Apr 2015 11:12:42 -0000

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=199641

            Bug ID: 199641
           Summary: Growfs does not compile in debugmode  (GFSDBG)
           Product: Base System
           Version: 10.1-STABLE
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: bin
          Assignee: freebsd-bugs@FreeBSD.org
          Reporter: wjw@digiware.nl

cd /usr/src/sbin/growfs
make -DGFSDBG
Returns errors while building.

Probably because the debug code is normally execluded.

2* int versus u_int_32
2* char-pointer cast to uint-pointer

First is fixed by changing type
Second is fixed by getting the compiler to ignore the warning.
Which IMHO is valid since compiling GFSDBG is only done if you sort of know
what is going on.....

Perhaps a suggestion on debugging on the manual page would be approriate as
well.

Tested on 10.1, but probably valid on others as well.

svn diff:
Index: sbin/growfs/Makefile
===================================================================
--- sbin/growfs/Makefile        (revision 281869)
+++ sbin/growfs/Makefile        (working copy)
@@ -17,6 +17,8 @@

 .if defined(GFSDBG)
 SRCS+=  debug.c
+CFLAGS+=-DFS_DEBUG
+NO_WCAST_ALIGN= yes
 .endif

 DPADD= ${LIBUTIL}
Index: sbin/growfs/growfs.c
===================================================================
--- sbin/growfs/growfs.c        (revision 281869)
+++ sbin/growfs/growfs.c        (working copy)
@@ -161,7 +161,7 @@
 #ifdef FS_DEBUG
        {
                struct csum *dbg_csp;
-               int dbg_csc;
+               u_int32_t dbg_csc;
                char dbg_line[80];

                dbg_csp = fscs;
@@ -242,7 +242,7 @@
 #ifdef FS_DEBUG
        {
                struct csum     *dbg_csp;
-               int     dbg_csc;
+               u_int32_t       dbg_csc;
                char    dbg_line[80];

                dbg_csp = fscs;

-- 
You are receiving this mail because:
You are the assignee for the bug.