From owner-cvs-src@FreeBSD.ORG Fri Nov 14 09:33:51 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E0AFB16A4CE for ; Fri, 14 Nov 2003 09:33:51 -0800 (PST) Received: from smtp.mho.com (smtp.mho.net [64.58.4.6]) by mx1.FreeBSD.org (Postfix) with SMTP id 95F9843FF2 for ; Fri, 14 Nov 2003 09:33:47 -0800 (PST) (envelope-from scottl@freebsd.org) Received: (qmail 63035 invoked by uid 1002); 14 Nov 2003 17:33:46 -0000 Received: from unknown (HELO ?10.4.1.5?) (64.58.1.252) by smtp.mho.net with SMTP; 14 Nov 2003 17:33:46 -0000 Date: Fri, 14 Nov 2003 10:35:43 -0700 (MST) From: Scott Long X-X-Sender: scottl@pooker.samsco.home To: "M. Warner Losh" In-Reply-To: <20031114.095339.121107822.imp@bsdimp.com> Message-ID: <20031114103425.J11888@pooker.samsco.home> References: <200311141635.hAEGZqiT031464@green.bikeshed.org> <20031114.095339.121107822.imp@bsdimp.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: green@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org cc: cvs-src@FreeBSD.org Subject: Re: cvs commit: src/sys/conf kern.post.mk kmod.mk X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Nov 2003 17:33:52 -0000 On Fri, 14 Nov 2003, M. Warner Losh wrote: > In message: <200311141635.hAEGZqiT031464@green.bikeshed.org> > "Brian F. Feldman" writes: > : "M. Warner Losh" wrote: > : > In message: <200311141604.hAEG4BCg041862@repoman.freebsd.org> > : > Brian Feldman writes: > : > : Include opt_global.h in the modules build, when building from a normal > : > : kernel build. This makes it possible for me not to get pissed off that > : > : random.ko crashes the system trying to rdtsc() when the i386/cpu.h > : > : support code decides it's okay to call that op when neither I386_CPU or > : > : I486_CPU is defined. I guess it also makes WITNESS/INVARIANTS defines > : > : get picked up by the modules. > : > > : > I've been polishing similar things that I'd hoped to get into this > : > release. I'll try to finish them up today. You should really talk to > : > people before doing these things. > : > : I know that you have been working on that, and I'm very happy to see that. > : If this makes things difficult of course there's no reason not to remove it > : other than being an interim solution for crashes people might see now. If I > : didn't know you were working on the smarter module build, I would have just > : gone through all the headers and tried to remove all the "harmful" uses of > : constants defined by opt_global.h (which I feel is very much not a > : "solution", but either way... getting rid of the problem is important, and I > : don't think that the importance is particularly diminished just because the > : bugs have existed for a while, IMHO). > > This actually is a good part of the 'first step' that I've been > wanting to get done. It just suprised me, that's all, to see it > committed the day we're trying to freeze for 5.2. > > Warner > > 5.2 code freeze does not happen until Monday. http://www.freebsd.org/releases/5.2R/schedule.html I've announced the schedule on a regular basis for the last 2+ weeks. Scott