From owner-svn-src-head@freebsd.org Sat Aug 8 01:10:32 2015 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1B2579B57B6; Sat, 8 Aug 2015 01:10:32 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-io0-x22e.google.com (mail-io0-x22e.google.com [IPv6:2607:f8b0:4001:c06::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id DEF89F1D; Sat, 8 Aug 2015 01:10:31 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: by iodb91 with SMTP id b91so66923906iod.1; Fri, 07 Aug 2015 18:10:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=/33xD2efnuo3/GWXg7WtOyI3vH+DwZrElTIf+2Pr4M4=; b=PBe9yUysUgIFPBXs2l2cO815+/yBb0ZM3y9SKl6VaUOGS1oIeWzku73vCcJNvkYpPw PbhtNxLEOPdYAXIXCLtvgZogn/1PINaHchGmxBuUKkN7H89u4gkNQ6F4FaWUFEBuVLeR WknLyx/KMNSnqIZm3jjZ0ZgttxEC0bZVFJJlKkTgTxn2nXU/P1BYiPbqjbL9zZ2BSJWn iF0G5QbYXW45nnmp3QHP6ln/fAueYPIijH0twMgkV3jfsb8V57SAOENljGBpo8RMhAm3 8t9NJN3hPR42a2QA4jFTpMCoaM85r7qnKvHgFfbFxvlsG/VMPlUiAGjZzrq0cKBgEFBd ZDEQ== MIME-Version: 1.0 X-Received: by 10.107.169.138 with SMTP id f10mr10731985ioj.75.1438996231365; Fri, 07 Aug 2015 18:10:31 -0700 (PDT) Received: by 10.36.38.133 with HTTP; Fri, 7 Aug 2015 18:10:31 -0700 (PDT) In-Reply-To: References: <201508071143.t77BhFvr007283@repo.freebsd.org> <72035147-7F25-4E63-B60B-A19A2FB58117@FreeBSD.org> Date: Fri, 7 Aug 2015 18:10:31 -0700 Message-ID: Subject: Re: svn commit: r286410 - in head: etc etc/rc.d sys/dev/ath sys/dev/ath/ath_rate/sample sys/dev/bwi sys/dev/bwn sys/dev/if_ndis sys/dev/ipw sys/dev/iwi sys/dev/iwn sys/dev/malo sys/dev/mwl sys/dev/ral ... From: Adrian Chadd To: "Bjoern A. Zeeb" Cc: Gleb Smirnoff , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 08 Aug 2015 01:10:32 -0000 Gleb, At least for ath(4), TDMA doesn't work, ATH_DEBUG doesn't work, IFF_DUMPPKTS() has an extra brace, and that's what I found in the last 15 minutes of this, compiling one of the many MIPS kernels that we have in -HEAD for hardware that people are using. I left this up to you to run to completion, and a single 'make universe' would've found these issues. Instead, head is actively broken leading into a weekend. There's at least one report of a hostapd problem, which indicates that hostapd didn't get enough testing. I don't know if adhoc or monitor mode got tested. I understand if mesh/tdma weren't tested - I'm slowly chipping away at those. I've just reverted the work. Let's get all the debug stuff more thoroughly tested and get more exposure before we try to land this again. If there are any follow up issues with the reversion then please poke me and I'll get it tested. Thanks, -adrian On 7 August 2015 at 16:49, Adrian Chadd wrote: > Hi, > > Since I'm on holidays, and I really don't have time to tidy up after > this commit: > > * everyone can commit to the wireless stuff to get this fixed up and working; > * if hostap mode stays broken for more than 4 days, I'm going to back > all the changes out. > > (And yes, gleb did run this stuff by me a few times and I'm okay with > the general theory of this, but we'll see how it pans out. I'm totally > fine with completely rolling it back if it's a failed experiment.) > > > > -adrian