From owner-freebsd-ports-bugs@FreeBSD.ORG Thu Dec 8 16:41:00 2005 Return-Path: X-Original-To: freebsd-ports-bugs@hub.freebsd.org Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 92DDC16A420 for ; Thu, 8 Dec 2005 16:41:00 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4A0EF43D69 for ; Thu, 8 Dec 2005 16:40:13 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.3/8.13.3) with ESMTP id jB8Ge47q055563 for ; Thu, 8 Dec 2005 16:40:04 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.3/8.13.1/Submit) id jB8Ge4eB055562; Thu, 8 Dec 2005 16:40:04 GMT (envelope-from gnats) Resent-Date: Thu, 8 Dec 2005 16:40:04 GMT Resent-Message-Id: <200512081640.jB8Ge4eB055562@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, walter@pelissero.de Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7485B16A41F for ; Thu, 8 Dec 2005 16:33:31 +0000 (GMT) (envelope-from walter.pelissero@iesy.net) Received: from smtp.iesy.net (pip251.ish.de [80.69.98.251]) by mx1.FreeBSD.org (Postfix) with ESMTP id CE19143D5C for ; Thu, 8 Dec 2005 16:33:29 +0000 (GMT) (envelope-from walter.pelissero@iesy.net) Received: from zaphod.home.loc (pip250.ish.de [80.69.98.250]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.iesy.net (Postfix) with ESMTP id 01189B5E4 for ; Thu, 8 Dec 2005 17:33:26 +0100 (CET) Received: from zaphod.home.loc (localhost [127.0.0.1]) by zaphod.home.loc (8.13.4/8.13.3) with ESMTP id jB8GXIXl011304 for ; Thu, 8 Dec 2005 17:33:18 +0100 (CET) (envelope-from wcp@zaphod.home.loc) Received: (from wcp@localhost) by zaphod.home.loc (8.13.4/8.13.3/Submit) id jB8GXI3I011303; Thu, 8 Dec 2005 17:33:18 +0100 (CET) (envelope-from wcp) Message-Id: <200512081633.jB8GXI3I011303@zaphod.home.loc> Date: Thu, 8 Dec 2005 17:33:18 +0100 (CET) From: "Walter C. Pelissero" To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: ports/90107: cvsd imprisoned doesn't work with devfs X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: walter@pelissero.de List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Dec 2005 16:41:00 -0000 >Number: 90107 >Category: ports >Synopsis: cvsd imprisoned doesn't work with devfs >Confidential: no >Severity: serious >Priority: medium >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Thu Dec 08 16:40:04 GMT 2005 >Closed-Date: >Last-Modified: >Originator: Walter C. Pelissero >Release: FreeBSD 6.0-STABLE i386 >Organization: >Environment: System: FreeBSD zaphod.home.loc 6.0-STABLE FreeBSD 6.0-STABLE #0: Tue Nov 22 22:26:35 CET 2005 root@zaphod.home.loc:/usr/src/sys/i386/compile/TYAN-TIGER-MP i386 >Description: I've noticed that cvsd doesn't run with the new devfs infrastructure. This is due to the fact that cvsd-buildroot makes use of mknod to populate the dev directory, but device nodes created that way don't work any longer (at least on 6.0-STABLE). >How-To-Repeat: Install cvsd from ports. Configure (see cvsd.conf) to run in a chrooted jail. Try to do any operation with a remote cvs client; an error about the impossibility to open /dev/null should be reported. In fact: # cat /path/to/cvsd/jail/dev/null cat: null: Socket operation on non-socket Also note that: # mknod foo c 0 16 # cat foo cat: foo: Socket operation on non-socket >Fix: The workaround is fairly simple for cvsd. Here is a half-baked proposal: --- cvsd.sh.sample Sat Oct 1 12:50:44 2005 +++ cvsd.sh Thu Dec 8 17:09:37 2005 @@ -42,6 +42,10 @@ case "$1" in start) + mount -t devfs devfs $DEVDIR + devfs -m $DEVDIR rule apply hide + devfs -m $DEVDIR rule apply path null unhide + devfs -m $DEVDIR rule apply path zero unhide echo $ECHO_N "Starting $DESC: cvsd$ECHO_C" if [ -n "$PIDFILE" ] && [ -f "$PIDFILE" ] && \ kill -s 0 `cat $PIDFILE` > /dev/null 2>&1 @@ -72,6 +76,7 @@ echo " unable to stop, no PidFile!" exit 1 fi + umount $DEVDIR ;; restart|force-reload) $0 stop DEVDIR must be set somewhere else or guessed from cvsd.conf. cvsd-buildroot should be amended accordingly (it shouldn't do any mknod). >Release-Note: >Audit-Trail: >Unformatted: