From owner-svn-src-all@freebsd.org Thu Aug 6 05:26:49 2015 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 215919B5837; Thu, 6 Aug 2015 05:26:49 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id 29FFD7C1; Thu, 6 Aug 2015 05:26:46 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua [212.40.38.100]) by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id IAA13965; Thu, 06 Aug 2015 08:26:31 +0300 (EEST) (envelope-from avg@FreeBSD.org) Received: from localhost ([127.0.0.1]) by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD)) id 1ZNDhG-000Ffv-QW; Thu, 06 Aug 2015 08:26:30 +0300 Message-ID: <55C2EFD1.1080308@FreeBSD.org> Date: Thu, 06 Aug 2015 08:25:37 +0300 From: Andriy Gapon User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Glen Barber , "K. Macy" , Pawel Jakub Dawidek CC: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" , Xin Li Subject: Re: svn commit: r285021 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs References: <201507020832.t628W3WJ002944@repo.freebsd.org> <55BF6A84.1040808@FreeBSD.org> <20150806021723.GB72832@garage.freebsd.pl> <20150806022247.GG1484@FreeBSD.org> <20150806030733.GI1484@FreeBSD.org> In-Reply-To: <20150806030733.GI1484@FreeBSD.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Aug 2015 05:26:49 -0000 On 06/08/2015 06:07, Glen Barber wrote: > On Wed, Aug 05, 2015 at 08:04:55PM -0700, K. Macy wrote: >> On Wed, Aug 5, 2015 at 7:22 PM, Glen Barber wrote: >>> On Thu, Aug 06, 2015 at 04:17:23AM +0200, Pawel Jakub Dawidek wrote: >>>> On Mon, Aug 03, 2015 at 04:20:04PM +0300, Andriy Gapon wrote: >>>>> On 30/07/2015 10:24, K. Macy wrote: >>>>>> Just FYI this change introduces a deadlock with with the >>>>>> spa_namespace_lock. Mount will be holding this lock while trying >>>>>> to acquire the spa_namespace_lock. zfskern on the other hand >>>>>> holds the spa_namespace_lock when calling zfs_freebsd_access >>>>>> which in turn tries to acquire the teardown lock. >>>>> >>>>> I missed the fact that zpool.cache file is being written with >>>>> spa_namespace_lock held. I'll try to either resolve the problem in >>>>> the next day or I will revert the change. >>>> >>>> FYI, I'm hitting this deadlock on my laptop. Reverting the change >>>> fixes the problem. >>>> >>> >>> Since it is now 3 days after "I'll try to either resolve the problem >>> in the next day or I will revert the change", my view is that this >>> needs to be reverted now, if it hasn't been done already. >>> >> His proposed solution looks fine to me. Why don't we commit that? >> > > I must have missed the solution - was it part of this thread? If a > solution exists, then yes, that should be the fix instead. Sorry about this, again. I kind of hoped to get a review from Matt, but I guess I'll commit the potential fix sooner than later: https://reviews.freebsd.org/D3281 -- Andriy Gapon