From owner-svn-ports-head@FreeBSD.ORG  Wed May 29 15:50:40 2013
Return-Path: <owner-svn-ports-head@FreeBSD.ORG>
Delivered-To: svn-ports-head@freebsd.org
Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115])
 by hub.freebsd.org (Postfix) with ESMTP id 46463FA9;
 Wed, 29 May 2013 15:50:40 +0000 (UTC) (envelope-from adamw@adamw.org)
Received: from apnoea.adamw.org (apnoea.adamw.org [204.109.59.150])
 by mx1.freebsd.org (Postfix) with ESMTP id 21EA7380;
 Wed, 29 May 2013 15:50:40 +0000 (UTC)
Received: from mail.adamw.org (localhost [127.0.0.1])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by apnoea.adamw.org (Postfix) with ESMTPSA id D5E8511F805;
 Wed, 29 May 2013 11:44:44 -0400 (EDT)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8;
 format=flowed
Content-Transfer-Encoding: 8bit
Date: Wed, 29 May 2013 11:44:44 -0400
From: Adam Weinberger <adamw@adamw.org>
To: Jason Helfman <jgh@freebsd.org>
Subject: Re: svn commit: r319306 - in head/shells/fish: . files
In-Reply-To: <CAMuy=+gb2WMay7uKF7Pm7+9A56Xm2T8u71+uJtpE6R-mhBT7Mg@mail.gmail.com>
References: <201305281350.r4SDo0QX088856@svn.freebsd.org>
 <51A4F14F.7050903@passap.ru>
 <CAMuy=+gb2WMay7uKF7Pm7+9A56Xm2T8u71+uJtpE6R-mhBT7Mg@mail.gmail.com>
Message-ID: <3f5b65bcdb94d31d4e512585a160a997@mail.adamw.org>
X-Sender: adamw@adamw.org
User-Agent: banemail fence
Cc: svn-ports-head@freebsd.org, owner-ports-committers@freebsd.org,
 Martin Wilke <miwi@freebsd.org>, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org, Boris Samorodov <bsam@passap.ru>
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 29 May 2013 15:50:40 -0000

On 2013/05/29 01:00, Jason Helfman wrote:
> On Tue, May 28, 2013 at 11:02 AM, Boris Samorodov <bsam@passap.ru>
> wrote:
> 
>> 28.05.2013 17:50, Martin Wilke пишет:
>> 
>>>  post-install:
>> 
>>> +.for i in fish fish_indent fish_pager fishd mimedb
>>> +     @${STRIP_CMD} ${PREFIX}/bin/${i}
>>> +.endfor
>> 
>> Do we really allow dealing with files at $PREFIX?
> 
> This is the first time I've seen something like this, but I can't say
> it hasn't done before without more investigation. Beyond this, I don't
> see why this couldn't be done as a post-build target, but I also don't
> know if there are any issues preventing this route.

Many autotools-based programs relink libraries and executables during 
the install target. Sometimes waiting until it's been placed into PREFIX 
is the only way to access the final edition.

Also I'm not really sure why we wouldn't allow dealing with files at 
PREFIX in the manner that miwi's commit handles it.

To me, I'd think the bigger question is why it isn't stripping the 
executables already as part of the install target, as autotools stuff 
usually DTRT.

# Adam


---
Adam Weinberger
adamw@adamw.org
http://www.adamw.org

> 
> -jgh
> 
> --
> Jason Helfman          | FreeBSD Committer
> jgh@FreeBSD.org     | http://people.freebsd.org/~jgh [1]  | The
> Power to Serve
> 
> 
> Links:
> ------
> [1] http://people.freebsd.org/%7Ejgh