From owner-svn-ports-all@freebsd.org Sun Aug 7 14:59:45 2016 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C5F5BBB014B; Sun, 7 Aug 2016 14:59:45 +0000 (UTC) (envelope-from kevlo@ns.kevlo.org) Received: from ns.kevlo.org (220-135-115-6.HINET-IP.hinet.net [220.135.115.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "ns.kevlo.org", Issuer "ns.kevlo.org" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 809F91DC5; Sun, 7 Aug 2016 14:59:44 +0000 (UTC) (envelope-from kevlo@ns.kevlo.org) Received: from ns.kevlo.org (localhost [127.0.0.1]) by ns.kevlo.org (8.15.2/8.15.2) with ESMTPS id u77ExUMU011958 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Sun, 7 Aug 2016 22:59:31 +0800 (CST) (envelope-from kevlo@ns.kevlo.org) Received: (from kevlo@localhost) by ns.kevlo.org (8.15.2/8.15.2/Submit) id u77ExUk9011957; Sun, 7 Aug 2016 22:59:30 +0800 (CST) (envelope-from kevlo) Date: Sun, 7 Aug 2016 22:59:29 +0800 From: Kevin Lo To: Kubilay Kocak Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r419671 - in head/astro: . py-horoscopegenerator Message-ID: <20160807145929.GA11950@ns.kevlo.org> References: <201608050755.u757tYOi052449@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 07 Aug 2016 14:59:45 -0000 On Fri, Aug 05, 2016 at 06:09:45PM +1000, Kubilay Kocak wrote: > > On 5/08/2016 5:55 PM, Kevin Lo wrote: > > Author: kevlo > > Date: Fri Aug 5 07:55:33 2016 > > New Revision: 419671 > > URL: https://svnweb.freebsd.org/changeset/ports/419671 > > > > Log: > > Import py-horoscopegenerator 0.1.8 > > > > py-horoscopegenerator generates horoscopes using context-free grammar. > > > > Added: > > head/astro/py-horoscopegenerator/ > > head/astro/py-horoscopegenerator/Makefile (contents, props changed) > > head/astro/py-horoscopegenerator/distinfo (contents, props changed) > > head/astro/py-horoscopegenerator/pkg-descr (contents, props changed) > > Modified: > > head/astro/Makefile > > > > Modified: head/astro/Makefile > > ============================================================================== > > --- head/astro/Makefile Fri Aug 5 07:49:18 2016 (r419670) > > +++ head/astro/Makefile Fri Aug 5 07:55:33 2016 (r419671) > > @@ -82,6 +82,7 @@ > > SUBDIR += py-aipy > > SUBDIR += py-astLib > > SUBDIR += py-astropy > > + SUBDIR += py-horoscopegenerator > > SUBDIR += py-pyfits > > SUBDIR += py-pymetar > > SUBDIR += py-pywapi > > > > Added: head/astro/py-horoscopegenerator/Makefile > > ============================================================================== > > --- /dev/null 00:00:00 1970 (empty, because file is newly added) > > +++ head/astro/py-horoscopegenerator/Makefile Fri Aug 5 07:55:33 2016 (r419671) > > @@ -0,0 +1,22 @@ > > +# $FreeBSD$ > > + > > +PORTNAME= horoscopegenerator > > +PORTVERSION= 0.1.8 > > +CATEGORIES= astro python > > +MASTER_SITES= CHEESESHOP > > +DISTNAME= ${PORTNAME:S/h/H/:S/g/G/}-${PORTVERSION} > > +PKGNAMEPREFIX= ${PYTHON_PKGNAMEPREFIX} > > + > > +MAINTAINER= kevlo@FreeBSD.org > > +COMMENT= Generate horoscopes using context-free grammar > > + > > +LICENSE= MIT > > + > > +NO_ARCH= yes > > +USES= python > > Limited to :2.7 [1] > > [1] > https://github.com/mouse-reeve/horoscope-generator/blob/master/setup.py#L32 It runs fine under Python 3. > > +USE_PYTHON= distutils autoplist > > + > > +RUN_DEPENDS= ${PYTHON_PKGNAMEPREFIX}six>=0:devel/py-six \ > > + ${PYTHON_PKGNAMEPREFIX}nltk>0:textproc/py-nltk > > Though it's listed in requirements.txt, I can't see six referenced in > setup.py (*_requires) which is the canonical place to obtain real > dependencies, as opposed to *.txt which are often used only for > development, provisioning, testing, or otherwise > non-'distribution/release' purposes. > > Could be a bug (not listed in install_requires), or a non-dependency. > > Either way worth it's worth testing (I cant see any import code for > six), and then reporting (or creating PR) upstream if necessary. Fixed in r419779. This fix was confirmed by upstream, thanks. > > > + > > +.include > > > > Added: head/astro/py-horoscopegenerator/distinfo > > ============================================================================== > > --- /dev/null 00:00:00 1970 (empty, because file is newly added) > > +++ head/astro/py-horoscopegenerator/distinfo Fri Aug 5 07:55:33 2016 (r419671) > > @@ -0,0 +1,3 @@ > > +TIMESTAMP = 1470381700 > > +SHA256 (HoroscopeGenerator-0.1.8.tar.gz) = 96b9f577f7024d131bd3a080a2e177494fa41a36d803bd5f0ec21133bad90073 > > +SIZE (HoroscopeGenerator-0.1.8.tar.gz) = 6443 > > > > Added: head/astro/py-horoscopegenerator/pkg-descr > > ============================================================================== > > --- /dev/null 00:00:00 1970 (empty, because file is newly added) > > +++ head/astro/py-horoscopegenerator/pkg-descr Fri Aug 5 07:55:33 2016 (r419671) > > @@ -0,0 +1,4 @@ > > +The HoroscopeGenerator produces horoscopes on demand using context-free > > +grammar. > > + > > +WWW: https://github.com/mouse-reeve/horoscope-generator > > > >