Date: Mon, 17 Nov 2014 21:21:11 +0300 From: Chagin Dmitry <dchagin@freebsd.org> To: Eric McCorkle <eric@metricspace.net>;, jhb@freebsd.org Cc: Adrian Chadd <adrian@freebsd.org>, "freebsd-acpi@freebsd.org" <freebsd-acpi@freebsd.org>, "freebsd-mobile@freebsd.org" <freebsd-mobile@freebsd.org> Subject: Re: Lenovo W540 blank screen on suspend/resume after update Message-ID: <20141117182111.GA2477@dchagin.static.corbina.net> In-Reply-To: <C0B09693-F50C-461B-942E-700E90A16535@metricspace.net> References: <54652C60.9050909@metricspace.net> <CAJ-VmokpzRd7hk42NtRWPsCwD1pm_n8kpS4Q7hkbVCgJ7rPpKQ@mail.gmail.com> <20141114161857.GA49507@dchagin.static.corbina.net> <C0B09693-F50C-461B-942E-700E90A16535@metricspace.net>
next in thread | previous in thread | raw e-mail | index | archive | help
--GID0FwUMdk1T2AWN
Content-Type: multipart/mixed; boundary="xHFwDpU9dbj6ez1V"
Content-Disposition: inline
--xHFwDpU9dbj6ez1V
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Fri, Nov 14, 2014 at 03:33:26PM -0500, Eric McCorkle wrote:
> Sorry, don't remember the working version.
>=20
> I have acpi_video compiled in to my kernel. I've tried it with both vt an=
d sc and gotten the same result.=20
>=20
> Might try to do more diagnostics this weekend.=20
>=20
> On November 14, 2014 11:18:57 AM EST, Chagin Dmitry <dchagin@freebsd.org>=
wrote:
> >On Thu, Nov 13, 2014 at 02:13:35PM -0800, Adrian Chadd wrote:
> >> Hi,
> >>=20
> >> Does it stay blank if you have acpi_video (+ vt) loaded?
> >>=20
> >> What was the revision of 11 you were previously running?
> >>=20
> >>=20
> >>=20
> >> -adrian
> >>=20
> >>=20
> >> On 13 November 2014 14:10, Eric McCorkle <eric@metricspace.net>
> >wrote:
> >> > Hello,
> >> >
> >> > I updated my kernel and userland with a fresh update from 11
> >yesterday, and
> >> > I'm now seeing a blank screen after suspend/resume, where it was
> >working
> >> > fine previously.
> >> >
> >> > I had been trying out the new vt console, so I switched back to sc,
> >but the
> >> > blank screen is still there.
> >> >
> >> > Sorry, I don't have any information beyond this (quite busy these
> >days).
> >> >
> >> > Eric
> >
> >
> >Lenovo t540, same here. r274463 + sc. resume worked two weeks ago.
> >
> >
> >--=20
> >Have fun!
> >chd
>=20
try attached patch. it seems we should take a close look to other
PCIB_POWER_FOR_SLEEP() calls.=20
--=20
Have fun!
chd
--xHFwDpU9dbj6ez1V
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment; filename="pci.patch"
Content-Transfer-Encoding: quoted-printable
diff --git a/sys/dev/pci/pci.c b/sys/dev/pci/pci.c
index d2ac111..8e6b87b 100644
--- a/sys/dev/pci/pci.c
+++ b/sys/dev/pci/pci.c
@@ -3637,7 +3637,6 @@ static void
pci_set_power_child(device_t dev, device_t child, int state)
{
struct pci_devinfo *dinfo;
- device_t pcib;
int dstate;
=20
/*
@@ -3647,11 +3646,10 @@ pci_set_power_child(device_t dev, device_t child, i=
nt state)
* device power. Skip children who aren't attached since they
* are handled separately.
*/
- pcib =3D device_get_parent(dev);
dinfo =3D device_get_ivars(child);
dstate =3D state;
if (device_is_attached(child) &&
- PCIB_POWER_FOR_SLEEP(pcib, child, &dstate) =3D=3D 0)
+ PCIB_POWER_FOR_SLEEP(dev, child, &dstate) =3D=3D 0)
pci_set_powerstate(child, dstate);
}
=20
--xHFwDpU9dbj6ez1V--
--GID0FwUMdk1T2AWN
Content-Type: application/pgp-signature
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
iEYEARECAAYFAlRqPJcACgkQ0t2Tb3OO/O0VFgCghHNMr8jynEH75SlnsU/wr9Le
8C8Ani8Kbngyi1Lmlo5LWP7NAe0EgM75
=26aN
-----END PGP SIGNATURE-----
--GID0FwUMdk1T2AWN--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20141117182111.GA2477>