Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 29 Jan 2015 16:10:19 +0000
From:      bugzilla-noreply@freebsd.org
To:        freebsd-ports-bugs@FreeBSD.org
Subject:   [Bug 197131] net-mgmt/netdot fails to build due to rrdtool path in var/Makefile
Message-ID:  <bug-197131-13-6WjRuxFqWr@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-197131-13@https.bugs.freebsd.org/bugzilla/>
References:  <bug-197131-13@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=197131

--- Comment #4 from nick@foobar.org ---
in order for the install target to be executed, the ports system will ensure
that the rrdtool command can be found in the default freebsd pkg search path,
which is:

/sbin:/bin:/usr/sbin:/usr/bin:/usr/local/sbin:/usr/local/bin

The install target will not proceed unless rrdtool is found.

tcsh rehash only affects the cache on the interactive shell.  If make is
executed, it will fork a new $SHELL for CLI commands, so 1. it will probably be
/bin/sh and 2. if it's tcsh, it will build up a new path cache on startup
anyway.

re: whether it's safer / better practice to use explicit paths, I have no
objection to using explicit paths for commands, but only if it's done properly.
 To do this properly in netdot, it would be necessary to restructure the
Makefiles to use e.g. autoconf, do an explicit search for whatever commands are
required, and then write out per-system Makefiles during the installation
process.

freebsd-specific hacks are a bad idea because they can't be pushed upstream, as
that will break on other systems.  Adding a local patch to the files/ directory
adds yet another thing to check when doing package upgrades.

If you want to see this fixed, you should talk to the netdot guys about
introducing autoconf support. Otherwise, the freebsd port installation will
work fine if you include your default package location in your PATH environment
variable.

I'll fix the PREFIX location because that is a bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-197131-13-6WjRuxFqWr>