From owner-freebsd-ports-bugs@FreeBSD.ORG Thu Jan 29 16:10:19 2015 Return-Path: Delivered-To: freebsd-ports-bugs@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 5E5FEC2B for ; Thu, 29 Jan 2015 16:10:19 +0000 (UTC) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 29CFBFAD for ; Thu, 29 Jan 2015 16:10:19 +0000 (UTC) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id t0TGAJjl034194 for ; Thu, 29 Jan 2015 16:10:19 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 197131] net-mgmt/netdot fails to build due to rrdtool path in var/Makefile Date: Thu, 29 Jan 2015 16:10:19 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: nick@foobar.org X-Bugzilla-Status: New X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-ports-bugs@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Jan 2015 16:10:19 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=197131 --- Comment #4 from nick@foobar.org --- in order for the install target to be executed, the ports system will ensure that the rrdtool command can be found in the default freebsd pkg search path, which is: /sbin:/bin:/usr/sbin:/usr/bin:/usr/local/sbin:/usr/local/bin The install target will not proceed unless rrdtool is found. tcsh rehash only affects the cache on the interactive shell. If make is executed, it will fork a new $SHELL for CLI commands, so 1. it will probably be /bin/sh and 2. if it's tcsh, it will build up a new path cache on startup anyway. re: whether it's safer / better practice to use explicit paths, I have no objection to using explicit paths for commands, but only if it's done properly. To do this properly in netdot, it would be necessary to restructure the Makefiles to use e.g. autoconf, do an explicit search for whatever commands are required, and then write out per-system Makefiles during the installation process. freebsd-specific hacks are a bad idea because they can't be pushed upstream, as that will break on other systems. Adding a local patch to the files/ directory adds yet another thing to check when doing package upgrades. If you want to see this fixed, you should talk to the netdot guys about introducing autoconf support. Otherwise, the freebsd port installation will work fine if you include your default package location in your PATH environment variable. I'll fix the PREFIX location because that is a bug. -- You are receiving this mail because: You are the assignee for the bug.