From owner-freebsd-net@FreeBSD.ORG Mon Aug 31 18:16:30 2009 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D4E8A106568F for ; Mon, 31 Aug 2009 18:16:30 +0000 (UTC) (envelope-from julian@elischer.org) Received: from outB.internet-mail-service.net (outb.internet-mail-service.net [216.240.47.225]) by mx1.freebsd.org (Postfix) with ESMTP id BFADA8FC24 for ; Mon, 31 Aug 2009 18:16:30 +0000 (UTC) Received: from idiom.com (mx0.idiom.com [216.240.32.160]) by out.internet-mail-service.net (Postfix) with ESMTP id C005BB9857; Mon, 31 Aug 2009 11:16:30 -0700 (PDT) X-Client-Authorized: MaGic Cook1e X-Client-Authorized: MaGic Cook1e Received: from julian-mac.elischer.org (home.elischer.org [216.240.48.38]) by idiom.com (Postfix) with ESMTP id 1E3FD2D6018; Mon, 31 Aug 2009 11:16:30 -0700 (PDT) Message-ID: <4A9C137C.7020303@elischer.org> Date: Mon, 31 Aug 2009 11:16:28 -0700 From: Julian Elischer User-Agent: Thunderbird 2.0.0.23 (Macintosh/20090812) MIME-Version: 1.0 To: stef@memberwebs.com Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: "freebsd-net@FreeBSD.org" Subject: Re: [patch] Unbreak setfib + routing daemons X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 Aug 2009 18:16:30 -0000 Stef Walter wrote: > Currently route messages are sent to all listeners of PF_ROUTE, > regardless or which FIB the listener socket was started on. > > The upshot of this is that one can't really use routing daemons together > with multiple FIBs. The routing daemon sees the messages from the > alternate FIBs and rapidly gets confused. > > In the future, someone might decide to expose FIB numbers in the route > messages themselves. This could allow routing daemons to filter them > out. Such a solution might be appropriate for FreeBSD 9.x and later, as > it would likely break API and ABI. In any case, I'm not really qualified > to argue the merits/problems of such an approach, and coding it is > beyond my abilities... > > Attached is a patch which fixes this problem in a simple way. It limits > route messages to listening PF_ROUTE sockets on the same FIB that the > route message was for. It compiles and works on 7.1+ and 8.0 and CURRENT. there are two ways to go with this one being what you have done teh other to add fib info to the messages, Apparently OpenBSD has implemented the second by re-using a disused field. (I'm ve only been told this second hand) I"ll look a tyour change and see what we can do. it might just make it to 8.1 at this stage but we can see what it looks like. > > FreeBSD PR: > > http://www.freebsd.org/cgi/query-pr.cgi?pr=kern/134931 how much have you tested this? > > How can I help this get into FreeBSD? It would be awesome if this fix or > one like it made it in before the 8.0 release. > > Cheers, > > Stef > > > > ------------------------------------------------------------------------ > > _______________________________________________ > freebsd-net@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-net > To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org"